exo unit test failing |
||||||||
Issue descriptionI number of exo unit tests are failing for local target=chromeos builds. Looks related to: https://chromium.googlesource.com/chromium/src/+/d8f4f642d72fc5fdb428f5a90ca207c2143a6f79 Here's an example: [ RUN ] PointerTest.OnPointerEnter Received signal 11 <unknown> 000000000000 #0 0x7f621b27317e base::debug::StackTrace::StackTrace() #1 0x7f621b272cbf base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f621b69e330 <unknown> #3 0x7f6212900956 <unknown> #4 0x7f62129009a0 <unknown> #5 0x00000046c495 __gnu_debug::_Safe_iterator_base::_Safe_iterator_base() #6 0x0000004ed270 __gnu_debug::_Safe_iterator<>::_Safe_iterator() #7 0x0000004effb8 std::__debug::map<>::erase() #8 0x0000004ebaaf std::__debug::map<>::erase() #9 0x0000004ea542 exo::CompositorFrameSinkHolder::ReclaimResources() #10 0x00000061f228 cc::mojom::MojoCompositorFrameSinkClientStubDispatch::Accept() #11 0x0000004ec4f3 cc::mojom::MojoCompositorFrameSinkClientStub<>::Accept() #12 0x7f621ba54dd2 mojo::InterfaceEndpointClient::HandleValidatedMessage() #13 0x7f621ba547c1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() #14 0x7f621ba5276a mojo::FilterChain::Accept() #15 0x7f621ba56656 mojo::InterfaceEndpointClient::HandleIncomingMessage() #16 0x7f621ba6747a mojo::internal::MultiplexRouter::ProcessIncomingMessage() #17 0x7f621ba66c04 mojo::internal::MultiplexRouter::Accept() #18 0x7f621ba5276a mojo::FilterChain::Accept() #19 0x7f621ba47735 mojo::Connector::ReadSingleMessage() #20 0x7f621ba48259 mojo::Connector::ReadAllAvailableMessages() #21 0x7f621ba480e1 mojo::Connector::OnHandleReadyInternal() #22 0x7f621ba47fbb mojo::Connector::OnWatcherHandleReady() #23 0x7f621ba4a2cc _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIPS3_JjEEEvS5_OT_DpOT0_ #24 0x7f621ba4a1d6 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_ #25 0x7f621ba4a167 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOj #26 0x7f621ba4a06c _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEOj #27 0x7f621ba1469f base::internal::RunMixin<>::Run() #28 0x7f621ba140fd mojo::Watcher::OnHandleReady() #29 0x7f621ba14e5e _ZN4base8internal13FunctorTraitsIMN4mojo7WatcherEFvjEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKjEEEvS5_OT_DpOT0_ #30 0x7f621ba14cdf _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo7WatcherEFvjERKNS_7WeakPtrIS5_EEJRKjEEEvOT_OT0_DpOT1_ #31 0x7f621ba14c53 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo7WatcherEFvjEJNS_7WeakPtrIS4_EEjEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_jEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #32 0x7f621ba14b3c _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo7WatcherEFvjEJNS_7WeakPtrIS4_EEjEEEFvvEE3RunEPNS0_13BindStateBaseE #33 0x7f621b279041 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv #34 0x7f621b278a29 base::debug::TaskAnnotator::RunTask() #35 0x7f621b2fc41f base::MessageLoop::RunTask() #36 0x7f621b2fc684 base::MessageLoop::DeferOrRunPendingTask() #37 0x7f621b2fc96e base::MessageLoop::DoWork() #38 0x7f621b31239c base::MessagePumpGlib::HandleDispatch() #39 0x7f621b312a61 base::(anonymous namespace)::WorkSourceDispatch() #40 0x7f6211cc2e04 g_main_context_dispatch #41 0x7f6211cc3048 <unknown> #42 0x7f6211cc30ec g_main_context_iteration #43 0x7f621b31249f base::MessagePumpGlib::Run() #44 0x7f621b2fbfe5 base::MessageLoop::RunHandler() #45 0x7f621b39b899 base::RunLoop::Run() #46 0x7f621b39bad9 base::RunLoop::RunUntilIdle() #47 0x000000840f81 ash::test::AshTestHelper::RunAllPendingInMessageLoop() #48 0x00000083ecd1 ash::test::AshTestBase::RunAllPendingInMessageLoop() #49 0x00000083ec6e ash::test::AshTestBase::TearDown() #50 0x0000006d4d80 exo::test::ExoTestBase::TearDown() #51 0x000000873e3e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #52 0x000000863f02 testing::internal::HandleExceptionsInMethodIfSupported<>() #53 0x000000858bbb testing::Test::Run() #54 0x0000008592ad testing::TestInfo::Run() #55 0x00000085984f testing::TestCase::Run() #56 0x00000085eb9c testing::internal::UnitTestImpl::RunAllTests() #57 0x0000008777be testing::internal::HandleSehExceptionsInMethodIfSupported<>() #58 0x0000008656e2 testing::internal::HandleExceptionsInMethodIfSupported<>() #59 0x00000085e83f testing::UnitTest::Run() #60 0x000000805201 RUN_ALL_TESTS() #61 0x000000804142 base::TestSuite::Run() staraz@, can you take a look?
,
Dec 22 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d40f036aa8e40227403313246418c4ce8b908368 commit d40f036aa8e40227403313246418c4ce8b908368 Author: staraz <staraz@chromium.org> Date: Wed Jan 04 00:46:13 2017 Buffer holds reference to CompositorFrameSinkHolder so the CompositorFrameSinkHolder lives until resources are released or Buffer is destroyed. CompositorFrameSinkHolder no longer holds references to itself in the field release_callback_. BUG= 675004 Review-Url: https://codereview.chromium.org/2584953002 Cr-Commit-Position: refs/heads/master@{#441269} [modify] https://crrev.com/d40f036aa8e40227403313246418c4ce8b908368/components/exo/buffer.cc [modify] https://crrev.com/d40f036aa8e40227403313246418c4ce8b908368/components/exo/buffer.h [modify] https://crrev.com/d40f036aa8e40227403313246418c4ce8b908368/components/exo/buffer_unittest.cc [modify] https://crrev.com/d40f036aa8e40227403313246418c4ce8b908368/components/exo/compositor_frame_sink_holder.cc [modify] https://crrev.com/d40f036aa8e40227403313246418c4ce8b908368/components/exo/compositor_frame_sink_holder.h [modify] https://crrev.com/d40f036aa8e40227403313246418c4ce8b908368/components/exo/surface.cc
,
Jan 4 2017
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29140a418ac170e40b978cee388163cca308b723 commit 29140a418ac170e40b978cee388163cca308b723 Author: reveman <reveman@chromium.org> Date: Wed Jan 11 21:55:41 2017 exo: CompositorFrameSink code cleanup. Update comments to reflect latest code and remove unncessary function and if-statements. BUG= 675004 Review-Url: https://codereview.chromium.org/2625153002 Cr-Commit-Position: refs/heads/master@{#442998} [modify] https://crrev.com/29140a418ac170e40b978cee388163cca308b723/components/exo/buffer.h [modify] https://crrev.com/29140a418ac170e40b978cee388163cca308b723/components/exo/compositor_frame_sink.cc [modify] https://crrev.com/29140a418ac170e40b978cee388163cca308b723/components/exo/compositor_frame_sink.h
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by staraz@chromium.org
, Dec 16 2016