New issue
Advanced search Search tips

Issue 674975 link

Starred by 1 user
Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Should enforce when Cronet API constructors called

Project Member Reported by pauljensen@chromium.org, Dec 16 2016 
We're going to be strict about enforcing when Cronet implementation code calls Cronet API methods (see https://codereview.chromium.org/2440613003/), but we're adding an exclusion for constructors.  Every implementation class that extends an API class will call them (i.e. super()).  The chances of this causing problems seems like it might be less than other API calls because hopefully the implementation shouldn't be constructing API classes if the API doesn't need/use them, but the potential for problems still exists.

Comment 1 by kapishnikov@chromium.org, Dec 29 2016 

Should we implement a static check that prevents from adding new constructors to an existing class? The first time we release an API class, the set of its constructors should be frozen.

Comment 2 by mef@chromium.org, Jan 10 2017

Status: Available (was: Untriaged)
Not a high priority.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment