Password update prompt on desktop & iOS shows Smart Lock, on Android it shows Google Chrome |
||
Issue descriptionSupposing that the user is syncing passwords without custom passphrase, and that the "SmartLockBrandingSavePromptOnly" experiment is on (should be 100% true since today), there is the following inconsistency in Chrome's UI: On desktop platforms and iOS, if Chrome asks the user to update password, it will ask them whether they want Google Smart Lock to do that. On Android, it will ask them about Google Chrome. @sabineb confirmed that it should be consistently Smart Lock across all platforms. Notes: * Even on Android, saving prompt shows Smart Lock. * Code pointers: - Wrong call in UpdatePasswordInfoBarDelegate [1] - Correct call in SavePasswordInfoBarDelegate [2] - Desktop equivalent [3] - iOS equivalent [4] [1] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/update_password_infobar_delegate_android.cc?rcl=0&l=28 [2] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/save_password_infobar_delegate_android.cc?type=cs&sq=package:chromium&l=35 [3] https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc?rcl=0&l=489 [4] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/save_password_infobar_delegate_android.cc?type=cs&sq=package:chromium&l=35
,
Dec 19 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 19 2016