New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674969 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Password update prompt on desktop & iOS shows Smart Lock, on Android it shows Google Chrome

Project Member Reported by vabr@chromium.org, Dec 16 2016

Issue description

Supposing that the user is syncing passwords without custom passphrase, and that the "SmartLockBrandingSavePromptOnly" experiment is on (should be 100% true since today), there is the following inconsistency in Chrome's UI:

On desktop platforms and iOS, if Chrome asks the user to update password, it will ask them whether they want Google Smart Lock to do that.

On Android, it will ask them about Google Chrome.


@sabineb confirmed that it should be consistently Smart Lock across all platforms.

Notes:
* Even on Android, saving prompt shows Smart Lock.
* Code pointers:
  - Wrong call in UpdatePasswordInfoBarDelegate [1]
  - Correct call in SavePasswordInfoBarDelegate [2]
  - Desktop equivalent [3]
  - iOS equivalent [4]


[1] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/update_password_infobar_delegate_android.cc?rcl=0&l=28
[2] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/save_password_infobar_delegate_android.cc?type=cs&sq=package:chromium&l=35
[3] https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc?rcl=0&l=489
[4] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/save_password_infobar_delegate_android.cc?type=cs&sq=package:chromium&l=35
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74b5e0999e79581da4a652b06201e92abb47ebfe

commit 74b5e0999e79581da4a652b06201e92abb47ebfe
Author: vabr <vabr@chromium.org>
Date: Mon Dec 19 10:21:37 2016

Fix branding in the update prompt on Android

Currently, the update prompt only refers to password manager as "Smart Lock" if
the PasswordBranding experiment group is SmartLockBranding. The save prompt and
both prompts on all other platforms (desktop + iOS) also accept the group
SmartLockBrandingSavePromptOnly.

This CL fixes the Android update prompt to follow the rest.

R=dvadym@chromium.org
BUG= 674969 

Review-Url: https://codereview.chromium.org/2582613003
Cr-Commit-Position: refs/heads/master@{#439448}

[modify] https://crrev.com/74b5e0999e79581da4a652b06201e92abb47ebfe/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

Comment 2 by vabr@chromium.org, Dec 19 2016

Status: Fixed (was: Started)

Sign in to add a comment