New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674967 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Consider using IsLowEndDevice() in ShapeDetector

Project Member Reported by mcasas@chromium.org, Dec 16 2016

Issue description

Consider using IsLowEndDevice() [1] in ShapeDetector
to e.g. cap the size of the images to prevent OOO.



[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/MemoryCoordinator.h?sq=package:chromium&dr=CSs&rcl=1481890797&l=38
 

Comment 1 by junwei...@intel.com, Dec 27 2016

I am new to chromium project and I'm interested in shapeDetection.
Do you mean it's used to prevent OOM?

#1: Yes, the idea would be to review the current uses in the
ShapeDetector(s) of the images, and try to devise a better way
of handling images either in Blink or in the Java implementations
in situations of IsLowEndDevice().

Before contributing, please review [1], and familiarise yourself
with the tests for this feature, e.g. [2] and [3]. Cheers!


[1] https://dev.chromium.org/developers/contributing-code/external-contributor-checklist
[2] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/shapedetection/?q=LayoutTests+shapedetection&sq=package:chromium&dr
[3] https://cs.chromium.org/chromium/src/content/browser/shapedetection/shapedetection_browsertest.cc?dr&sq=package:chromium&l=1

Comment 3 by junwei...@intel.com, Sep 15 2017

There is a limit on decoded image named max_decoded_bytes_ [1] which has limited image decoded size on low end device in BlinkPlatformImpl::MaxDecodedImageBytes [2], I don't understand which part can cause OOM.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h?gsn=BMPImageDecoder&l=370
[2] https://cs.chromium.org/chromium/src/content/child/blink_platform_impl.cc?gsn=MaxDecodedImageBytes&l=777
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment