Layout test css3/fonts/font-style-matching-0 is consistently failing on WebKit Linux Trusty Leak |
||||
Issue descriptionSuspected patches: https://chromium.googlesource.com/chromium/src/+/90d4ea3d543f0031769b3aacac2d3e084b95fb7d https://chromium.googlesource.com/chromium/src/+/bf9901feb0c46cefbd5e7af40fe252a6a92d52cb Example buildbot log: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/802 Builder WebKit Linux Trusty Leak Build #802 Failed steps failed webkit_tests Test error log: According to the CSS3 Fonts Module, Step 4 or the Font Style Matching Algorithm ( https://drafts.csswg.org/css-fonts-3/#font-style-matching ) must narrow down the available font faces by finding the nearest match in the following order of precedence: stretch, style, weight. abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg Testing font set variations 0 to 2 out of 0-26 Available fonts updated: ["condensed_normal_100","condensed_normal_900","condensed_italic_100","condensed_italic_900","expanded_normal_100","expanded_normal_900","expanded_italic_100","expanded_italic_900"] #condensed_normal_100 Expected: condensed normal 100 Actual: Times New Roman FAIL
,
Dec 16 2016
Another two tests have started failing on the same bot: css3/fonts/font-style-matching-6.html virtual/threaded/printing/offscreencanvas-2d-printing.html
,
Dec 16 2016
None of those font tests failed with the first build with my patch, so if they are caused by that change, it's flaky, not consistent. I did land some other changes later on, though. Could be things in combination. I can try to see if I can reproduce on Linux running the tests repeatedly. I just noticed the last build was green again. Let's see how it develops.
,
Dec 19 2016
,
Dec 19 2016
Sorry for the delay. I couldn't reproduce these issues in my local environment. I'll try it again when my code get updated.
,
Dec 19 2016
,
Dec 19 2016
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/357396ffe3cc7ace113783f25e088d08e615b08b commit 357396ffe3cc7ace113783f25e088d08e615b08b Author: rune <rune@opera.com> Date: Mon Dec 19 18:39:38 2016 Get rid of @font-face resource leak. Clear the StyleEngine of css connected fonts on detach(). This used to be saved by an active stylesheet update, it seems. With the new active stylesheet update this is done more selectively and it might have been done when document going inactive before. Clearing the font cache on detach fixes the leak issues in css3/fonts. TEST=css3/fonts/ BUG= 674934 Review-Url: https://codereview.chromium.org/2582413002 Cr-Commit-Position: refs/heads/master@{#439510} [modify] https://crrev.com/357396ffe3cc7ace113783f25e088d08e615b08b/third_party/WebKit/Source/core/dom/StyleEngine.cpp
,
Dec 19 2016
Bot green for eight consecutive builds. Closing. |
||||
►
Sign in to add a comment |
||||
Comment 1 by nek...@chromium.org
, Dec 16 2016