canMakePayment() should return true if user has a payment app with an instrument or a credit card with valid name and number.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc9f82823179751d15790d2347e1f0e83aaf4b13 commit dc9f82823179751d15790d2347e1f0e83aaf4b13 Author: rouslan <rouslan@chromium.org> Date: Mon Dec 19 16:23:18 2016 Do not require billing address for canMakePayment(). PaymentRequest.canMakePayment() should return true if user has a payment app with an instrument or a credit card with valid name and number. BUG= 674926 Review-Url: https://codereview.chromium.org/2558993003 Cr-Commit-Position: refs/heads/master@{#439486} [modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java [modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java [modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java [modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
Your change meets the bar and is auto-approved for M56 (branch: 2924)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dae509e7efb610d6c00d743f7e68fc097dff8024 commit dae509e7efb610d6c00d743f7e68fc097dff8024 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Mon Dec 19 18:02:03 2016 [Merge M-56] Do not require billing address for canMakePayment(). PaymentRequest.canMakePayment() should return true if user has a payment app with an instrument or a credit card with valid name and number. BUG= 674926 Review-Url: https://codereview.chromium.org/2558993003 Cr-Commit-Position: refs/heads/master@{#439486} (cherry picked from commit dc9f82823179751d15790d2347e1f0e83aaf4b13) Review-Url: https://codereview.chromium.org/2590543002 . Cr-Commit-Position: refs/branch-heads/2924@{#550} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java [modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java [modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java [modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
FYI, this is in M-56 now.
Comment 1 by bugdroid1@chromium.org
, Dec 19 2016