New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674926 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Do not require billing address for canMakePayment().

Project Member Reported by rouslan@chromium.org, Dec 16 2016

Issue description

canMakePayment() should return true if user has a payment app with an instrument or a credit card with valid name and number.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9f82823179751d15790d2347e1f0e83aaf4b13

commit dc9f82823179751d15790d2347e1f0e83aaf4b13
Author: rouslan <rouslan@chromium.org>
Date: Mon Dec 19 16:23:18 2016

Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG= 674926 

Review-Url: https://codereview.chromium.org/2558993003
Cr-Commit-Position: refs/heads/master@{#439486}

[modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java
[modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java
[modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java
[modify] https://crrev.com/dc9f82823179751d15790d2347e1f0e83aaf4b13/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Dec 19 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae509e7efb610d6c00d743f7e68fc097dff8024

commit dae509e7efb610d6c00d743f7e68fc097dff8024
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Dec 19 18:02:03 2016

[Merge M-56] Do not require billing address for canMakePayment().

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG= 674926 

Review-Url: https://codereview.chromium.org/2558993003
Cr-Commit-Position: refs/heads/master@{#439486}
(cherry picked from commit dc9f82823179751d15790d2347e1f0e83aaf4b13)

Review-Url: https://codereview.chromium.org/2590543002 .
Cr-Commit-Position: refs/branch-heads/2924@{#550}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java
[modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java
[modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java
[modify] https://crrev.com/dae509e7efb610d6c00d743f7e68fc097dff8024/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java

Cc: zkoch@chromium.org
Status: Fixed (was: Started)
FYI, this is in M-56 now.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment