New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674919 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-01-09
OS: Linux , Windows , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Restore text and icons after incomplete search, or not

Project Member Reported by hwi@chromium.org, Dec 16 2016

Issue description

Chrome Version: 55.0.2883.95 (Official Build) (64-bit)
OS: all desktop

What steps will reproduce the problem?
(1) See the bookmark icon in Omnibox in a tab
(2) Type in something in Omnibox
(3) See the bookmark icon removed
(4) Click out of Omnibox
(5) If you want to bookmark the page at this point, there's no way to bookmark. Also if you want to see the URL of this page, it becomes a bit difficult. To do so, the page needs to be refreshed.

What is the expected result?

This might be WAI, or something to think about. When the focus leaves Omnibox without any selection, should Chrome bring the URL and the bookmark icon back, and also page info icon? 

What happens instead?

Chrome leaves the typed text with search icon, and without the bookmark icon (also, all location bar icons next to it).

 
intialstate.png
303 KB View Download
leftomniboxtyped.png
253 KB View Download
Cc: groby@chromium.org jdonnelly@chromium.org ainslie@chromium.org
Owner: emilyschechter@chromium.org
Adding some omnibox folks. 

Hmm - my gut reaction is that clicking out of the omnibox without committing an edit/search should probably take you back to the pre-edit state that tells you what page you're looking at (showing icons and URL of the page - NTP might be a special case). That's what we do on mobile where the edit state is quite visually distinct from the steady state. 

One (imaginary?) risk is that people use today's Desktop behavior for complex workflows - ex: to copy and paste a few words from a page into the omnibox one by one as part of query formulation. 


It's definitely WAI but the original intention may or may not be correct.

My $0.02 is that this may be an an annoying case but that the alternatives are worse. Showing the bookmark icon while in edit state would be confusing. Being inside the omnibox is clearly meant to associate it with the URL. Canceling the edit state on focus loss would probably not affect most users but the occasional or even rare case when we threw away an edit state the user wanted to keep would be very unpleasant.
Components: UI>Browser>Omnibox
NextAction: 2018-01-09
Status: WontFix (was: Assigned)
We don't reset the edit state on focus loss precisely because of what comment 1 says: people copy and paste content from the page while editing.  People also interact with the page to scroll down, look at things, etc. to get more information and then go back to editing.  This behavior also matches other browsers and is longstanding.

The URL comes back if the user refreshes, navigates, or cancels the edit by hitting the esc key while focus is in the omnibox.  That's sufficient here.

The real fix for this, as with many omnibox problems, would be to divorce the passive, non-editable control that displays the current URL from the editable control that is always an inviting box to type in.  Sadly, I have no idea how to make that UI come to pass.

Given jdonnelly's and my agreement on this, closing.
The NextAction date has arrived: 2018-01-09

Sign in to add a comment