Restore text and icons after incomplete search, or not |
|||
Issue descriptionChrome Version: 55.0.2883.95 (Official Build) (64-bit) OS: all desktop What steps will reproduce the problem? (1) See the bookmark icon in Omnibox in a tab (2) Type in something in Omnibox (3) See the bookmark icon removed (4) Click out of Omnibox (5) If you want to bookmark the page at this point, there's no way to bookmark. Also if you want to see the URL of this page, it becomes a bit difficult. To do so, the page needs to be refreshed. What is the expected result? This might be WAI, or something to think about. When the focus leaves Omnibox without any selection, should Chrome bring the URL and the bookmark icon back, and also page info icon? What happens instead? Chrome leaves the typed text with search icon, and without the bookmark icon (also, all location bar icons next to it).
,
Dec 16 2016
It's definitely WAI but the original intention may or may not be correct. My $0.02 is that this may be an an annoying case but that the alternatives are worse. Showing the bookmark icon while in edit state would be confusing. Being inside the omnibox is clearly meant to associate it with the URL. Canceling the edit state on focus loss would probably not affect most users but the occasional or even rare case when we threw away an edit state the user wanted to keep would be very unpleasant.
,
Jun 6 2017
,
Jun 6 2017
We don't reset the edit state on focus loss precisely because of what comment 1 says: people copy and paste content from the page while editing. People also interact with the page to scroll down, look at things, etc. to get more information and then go back to editing. This behavior also matches other browsers and is longstanding. The URL comes back if the user refreshes, navigates, or cancels the edit by hitting the esc key while focus is in the omnibox. That's sufficient here. The real fix for this, as with many omnibox problems, would be to divorce the passive, non-editable control that displays the current URL from the editable control that is always an inviting box to type in. Sadly, I have no idea how to make that UI come to pass. Given jdonnelly's and my agreement on this, closing.
,
Jan 9 2018
The NextAction date has arrived: 2018-01-09 |
|||
►
Sign in to add a comment |
|||
Comment 1 by ainslie@chromium.org
, Dec 16 2016Owner: emilyschechter@chromium.org