WebViewTest.Shim_TestNestedSubframes Flaky on Mac10.9 Tests (dbg) bot |
|||||||
Issue description
,
Dec 16 2016
,
Dec 16 2016
lazyboy@: assigning to you since you are one of the owner of the affected test. Please triage further if you're not the right owner for this.
,
Dec 16 2016
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3feff87ab751bde268b46426e779a89abd2da90 commit f3feff87ab751bde268b46426e779a89abd2da90 Author: guidou <guidou@chromium.org> Date: Fri Dec 16 14:24:19 2016 Disable WebViewTest.Shim_TestNestedSubframes on Mac. The test has been flaking on at least one Mac bot. BUG=674904 TBR=lazyboy@chromium.org Review-Url: https://codereview.chromium.org/2582023002 Cr-Commit-Position: refs/heads/master@{#439099} [modify] https://crrev.com/f3feff87ab751bde268b46426e779a89abd2da90/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
Dec 16 2016
+James for triaging.
,
Jan 24 2018
,
Jan 24 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f3b60632d6a987c009e8f56d57efa968a1806d7 commit 4f3b60632d6a987c009e8f56d57efa968a1806d7 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Fri Mar 09 08:33:55 2018 Fix flaky <webview> tests. The two tests following tests are potentially flaky: * WebViewTests/WebViewTest.Shim_TestNestedSubframes/* * WebViewTests/WebViewTest.Shim_TestNestedCrossOriginSubframes/* Why are they flaky? webview.onloadstop event handler is defined. Once called, it causes a new navigation to happens in the webview. The navigation causes the handler to be called again. This is a loop. It wasn't expected to behave that way. If the nested iframe navigation happens quickly enough, the two time nested iframe navigation might not complete quickly enough and the postMessage() may not happens. The race condition may be unfavourable several time in a row and causes a test timeout. FYI: 1) This test was disabled on Mac. Maybe this CL fixes the issue? It should be verified on a device with this OS. 2) This test is flakier after enabling NavigationMojoResponse and applying this CL: https://chromium-review.googlesource.com/c/chromium/src/+/951243/6 That's understandable, this patch allows navigation to commit faster. Bug: 674904, 705744 Change-Id: Icf2debd095519221ff085cb3bacbc058c1806e86 Reviewed-on: https://chromium-review.googlesource.com/955585 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542064} [modify] https://crrev.com/4f3b60632d6a987c009e8f56d57efa968a1806d7/chrome/test/data/extensions/platform_apps/web_view/shim/main.js |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by guidou@chromium.org
, Dec 16 2016