New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674894 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 659205



Sign in to add a comment

Do not force offline version when open a recent / open tab suggestion

Project Member Reported by vitaliii@chromium.org, Dec 16 2016

Issue description

Currently we force offline version of the page, but as Patrick explained we should not. Offline Pages team should open offline version when they decide instead (e.g. when the user is offline).
 
Labels: zine-16-12-26
Status: Started (was: Assigned)
CL
https://codereview.chromium.org/2602953002
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff328670d44ef1bc94a93a6f64657f7be098b22e

commit ff328670d44ef1bc94a93a6f64657f7be098b22e
Author: vitaliii <vitaliii@chromium.org>
Date: Fri Dec 30 13:38:54 2016

[NTP::RecentTabs] Do not force offline version of the page when open.

When opening a recent tab suggestion, open the tab instead of forcing
offline page.  Previously, when user opened a recent tab suggestions,
its offline version was always oppened. After this CL, the tab is simply
opened and it is up to Offline Pages team whether to open its offline
version. This was a PM decision (to provide the same functionality as
tab switcher has).

BUG= 674894 

Review-Url: https://codereview.chromium.org/2602953002
Cr-Commit-Position: refs/heads/master@{#441030}

[modify] https://crrev.com/ff328670d44ef1bc94a93a6f64657f7be098b22e/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Status: Fixed (was: Started)

Sign in to add a comment