New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674892 link

Starred by 1 user
Status: Fixed
Owner:
vitaliii@chromium.org
Closed: Dec 2016
Cc:
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 659205



Sign in to add a comment

Show only "remove" in Recent / Open tabs context menu.

Project Member Reported by vitaliii@chromium.org, Dec 16 2016 
Patrick confirmed that we should show only "Remove".

Comment 1 by vitaliii@chromium.org, Dec 29 2016

Labels: zine-16-12-26
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20d7c954ace31673bc63845eb65798b52c333e2

commit f20d7c954ace31673bc63845eb65798b52c333e2
Author: vitaliii <vitaliii@chromium.org>
Date: Fri Dec 30 12:30:22 2016

[NTP::RecentTabs] Context menu: show only "Remove".

Show only "Remove" in recent (open) tab context menu.
All other context menu items make no sense for this section.

BUG= 674892 

Review-Url: https://codereview.chromium.org/2608713002
Cr-Commit-Position: refs/heads/master@{#441027}

[modify] https://crrev.com/f20d7c954ace31673bc63845eb65798b52c333e2/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Comment 4 by vitaliii@chromium.org, Dec 30 2016

Status: Fixed (was: Started)

Comment 5 by krav...@chromium.org, Jan 3 2017 

re-tested on M57 - 57.0.2790.0 build and still see the 4 option on NTP::RecentTabs option
Screenshot_2017-01-03-15-27-16.png
104 KB View Download

Comment 6 by vitaliii@chromium.org, Jan 4 2017 

Hi kravula@,

The version you used seems too old.

I just tested and this fix is visible in Canary 57.0.2969.0.
►

Sign in to add a comment