New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674891 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Background text Finished is read in voiceover mode in history

Project Member Reported by pmadalla@chromium.org, Dec 16 2016

Issue description

App Version: 56.0.2924.28 dev
iOS Version: 9.3.5, iOS 10
Device: iPad,iPhone

Precondition :
1.Enable voice over from device settings.
Device settings > General > Accessibility > Voiceover > ON
2. Have history data in History

Steps to reproduce:
1. Launch chrome.
2. Tap on Menu > History.
3. Tap on Search icon > Tap on cancel. 
4. Slightly slide to left on cancel 

Observed results:
Background text finished is heard

Expected results:
Background text should not be heard

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes in M55
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M56

Link to Video:
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpNjZHSzhfZHU5MFk/view?usp=sharing

 
Cc: jyqu...@chromium.org lpromero@chromium.org
Labels: ReleaseBlock-Stable M-56
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by pkl@chromium.org, Jan 3 2017

Cc: edchin@chromium.org
cc: edchin. It would be great if you have time to take a look at this (until sczs is back).

Comment 3 by sczs@google.com, Jan 3 2017

I have a fix for this and was waiting on Louis to come back and take a look 
https://codereview.chromium.org/2605023002/


Comment 4 by pkl@chromium.org, Jan 4 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0d82cf0179b873629fb2cbf2c253e9edc591920

commit c0d82cf0179b873629fb2cbf2c253e9edc591920
Author: sczs <sczs@google.com>
Date: Thu Jan 05 16:38:26 2017

Prevents history navigation items from being voice-over selectable while not visible.

Removing accessibility traits for these navigation items or disabling them, didn't
prevent them from being voice-over selectable while not visible due to the search bar
being presented on top.

Setting the view's accessibilityViewIsModal to YES fixed the problem but prevented
the history results from being voice-over selectable.

For these reasons the current approach was used.

BUG= 674891 

Review-Url: https://codereview.chromium.org/2605023002
Cr-Commit-Position: refs/heads/master@{#441672}

[modify] https://crrev.com/c0d82cf0179b873629fb2cbf2c253e9edc591920/ios/chrome/browser/ui/history/history_panel_view_controller.mm

Comment 6 by sczs@chromium.org, Jan 5 2017

Status: Fixed (was: Started)
CL Link: https://codereview.chromium.org/2605023002/

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.

Comment 8 by sczs@chromium.org, Jan 5 2017

Labels: -Merge-TBD Merge-Request-56
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 5 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M56
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
 pmadalla@ please verify this issue is fixed in the latest canary.
Status: Verified (was: Fixed)
Verified in 57.0.2974.0 canary, iPad Air iOS 9.3.5
Labels: -Hotlist-Merge-Review -Merge-Review-56 Merge-Approved-56
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 10 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 11 2017

Labels: -merge-approved-56 Merge-Merged-2924
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/b25c5f74590d53a95eac0908d5d84b359ce86111

commit b25c5f74590d53a95eac0908d5d84b359ce86111
Author: sczs <sczs@google.com>
Date: Wed Jan 11 11:54:00 2017

Verified on latest chrome beta version 56.0.2924.66 on iPhone 6s with iOS 10.2 and iPad Air with iOS 10.1.1, following the steps mentioned in comment #0.  Backgrounded text is not read with voice over : on.  Looks good.

Sign in to add a comment