Connect axis parameters to shaper |
||
Issue description
In HarfBuzzFace getScaledFont, we need something like this:
// Variation coordinates need to be available here, then
// set them on m_unscaledFont using something like.
SkTypeface* typeface = m_harfBuzzFontData->m_paint.getTypeface();
LOG(INFO) << "Axiscount " << typeface->getAxisCount();
SkFixed axes[typeface->getAxisCount()];
typeface->copyAxisValues(axes);
for (int i = 0; i < typeface->getAxisCount(); ++i) {
LOG(INFO) << "Axis " << i << " axisValue: " << SkFixedToFloat(axes[i]);
}
Connecting the Skia axis values to HarfBuzz.
,
Feb 16 2017
Change upcoming in https://skia-review.googlesource.com/c/7130/
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d6c0f9ad3a5d10c6ffc45119308026be3ec9a86 commit 9d6c0f9ad3a5d10c6ffc45119308026be3ec9a86 Author: drott <drott@chromium.org> Date: Mon Feb 27 18:08:14 2017 Wire up Skia axis parameters to HarfBuzz HarfBuzz requires the current axis coordinates to perform correct mark placement. Now that Skia provides the required API [1] we pass them from Skia to HarfBuzz. [1] https://skia-review.googlesource.com/c/8861/ TEST=Currently manually using Noto Sans Arabic, TODO issue 693065 BUG= 674879 Review-Url: https://codereview.chromium.org/2698043005 Cr-Commit-Position: refs/heads/master@{#453256} [modify] https://crrev.com/9d6c0f9ad3a5d10c6ffc45119308026be3ec9a86/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
,
Feb 28 2017
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ee8493dad2494e89b2417453c030da69f89137a commit 1ee8493dad2494e89b2417453c030da69f89137a Author: drott <drott@chromium.org> Date: Wed Mar 01 21:28:57 2017 Transfer variation axis coordinates including tags Skia may not always return the axis coordinates in order. Hence we should transfer tags and axis values, not only axis values in an assumed order. Doing this, we can also skip the additional copying and cast the data from Skia to HarfBuzz types straight away. We are ensuring the validity of the cast with a static_assert comparing the types. BUG= 674879 Review-Url: https://codereview.chromium.org/2730443002 Cr-Commit-Position: refs/heads/master@{#454039} [modify] https://crrev.com/1ee8493dad2494e89b2417453c030da69f89137a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by drott@chromium.org
, Jan 18 2017