New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674850 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Codesearch build failure on ChromiumOS Codesearc

Project Member Reported by emso@chromium.org, Dec 16 2016

Issue description

The codesearch compile step is failing on https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/3536/steps/compile/logs/stdio

Error:

FAILED: ui_arc_unittests 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -m64 -pthread -Werror --sysroot=../../build/linux/ubuntu_precise_amd64-sysroot -L/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/lib/x86_64-linux-gnu -L/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/usr/lib -Wl,-rpath-link=/b/build/slave/ChromiumOS_Codesearch/build/src/build/linux/ubuntu_precise_amd64-sysroot/usr/lib -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./ui_arc_unittests" -Wl,--start-group @"./ui_arc_unittests.rsp" ./libbase.so ./libmojo_system_impl.so ./libash.so ./libbindings.so ./libmojo_public_system_cpp.so ./libmojo_public_system.so ./libipc.so ./libgeometry.so ./libskia.so ./libbluetooth.so ./libchromeos.so ./libdbus.so ./libcc.so ./libcc_surfaces.so ./libdevice_gamepad.so ./libgpu.so ./libgles2_utils.so ./libgfx.so ./libicui18n.so ./libicuuc.so ./librange.so ./libgl_wrapper.so ./libplatform.so ./libgl_init.so ./libui_base.so ./libui_data_pack.so ./libevents_base.so ./liburl.so ./libaura.so ./libcompositor.so ./libmanager.so ./libdisplay.so ./libdisplay_types.so ./libdevices.so ./libviews.so ./libui_base_ime.so ./libevents.so ./libui_views_mus_lib.so ./libgles2_implementation.so ./libmojo_common_lib.so ./libwm.so ./libcrcrypto.so ./libboringssl.so ./libnet.so ./libprotobuf_lite.so ./libmessage_center.so ./libbase_i18n.so ./libuser_manager.so ./libkeyed_service_core.so ./libprefs.so ./libonc.so ./libkeyboard.so -Wl,--end-group  -ldl -lrt -ldbus-1 -lpthread -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 
gen/cc/ipc/mojo_compositor_frame_sink.mojom.h:328: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkStubDispatch::Accept(cc::mojom::MojoCompositorFrameSink*, mojo::internal::SerializationContext*, mojo::Message*)'
gen/cc/ipc/mojo_compositor_frame_sink.mojom.h:377: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkClientStubDispatch::Accept(cc::mojom::MojoCompositorFrameSinkClient*, mojo::internal::SerializationContext*, mojo::Message*)'
gen/cc/ipc/mojo_compositor_frame_sink.mojom.h:337: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkStubDispatch::AcceptWithResponder(cc::mojom::MojoCompositorFrameSink*, mojo::internal::SerializationContext*, mojo::Message*, mojo::MessageReceiverWithStatus*)'
gen/cc/ipc/mojo_compositor_frame_sink.mojom.h:386: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkClientStubDispatch::AcceptWithResponder(cc::mojom::MojoCompositorFrameSinkClient*, mojo::internal::SerializationContext*, mojo::Message*, mojo::MessageReceiverWithStatus*)'
../../mojo/public/cpp/bindings/lib/binding_state.h:109: error: undefined reference to 'cc::mojom::MojoCompositorFrameSink::Name_'
../../mojo/public/cpp/bindings/lib/binding_state.h:109: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkClient::Name_'
gen/cc/ipc/mojo_compositor_frame_sink.mojom.h:444: error: undefined reference to 'vtable for cc::mojom::MojoCompositorFrameSinkRequestValidator'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
gen/cc/ipc/mojo_compositor_frame_sink.mojom.h:448: error: undefined reference to 'vtable for cc::mojom::MojoCompositorFrameSinkClientRequestValidator'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
../../mojo/public/cpp/bindings/lib/interface_ptr_state.h:194: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkClient::Name_'
../../mojo/public/cpp/bindings/lib/interface_ptr_state.h:202: error: undefined reference to 'cc::mojom::MojoCompositorFrameSinkClientProxy::MojoCompositorFrameSinkClientProxy(mojo::MessageReceiverWithResponder*)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)


 

Comment 1 by emso@chromium.org, Dec 16 2016

We use a build configuration ('all') not used by any builder on the ChromiumOS waterfall, which is why this error is not showing up on the main builders. 

The error is happening for some files included for chromeos: https://cs.chromium.org/chromium/src/BUILD.gn?rcl=0&l=484

Rather than fix this particular error we should keep the code search builder in sync with a builder on the main waterfall.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6dc08cd4c697ad23c5f3529246e8401a500cc7b2

commit 6dc08cd4c697ad23c5f3529246e8401a500cc7b2
Author: Emma Soederberg <emso@chromium.org>
Date: Fri Dec 16 11:13:22 2016

Adds specific compile targets to the ChromiumOS codesearch builders.

We currently use the 'all' target which is causing compile problems for
code search that go unnoticed on the ChromiumOS waterfall. This solution
lists the targets currently used by 'Linux ChromiumOS Full' builder. This
connects the code search builder to the waterfal for the moment, but the
target lists can easily become out of sync.

The target used determines the coverage of cross-references in code search.
A failing build gives us nothing, and no config gives us all, so this is
best effort.

BUG= 674850 

Change-Id: I4374bcf805bc6ea597824596d0f33e08390156dd
Reviewed-on: https://chromium-review.googlesource.com/421506
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/6dc08cd4c697ad23c5f3529246e8401a500cc7b2/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json
[modify] https://crrev.com/6dc08cd4c697ad23c5f3529246e8401a500cc7b2/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch_Builder.json
[modify] https://crrev.com/6dc08cd4c697ad23c5f3529246e8401a500cc7b2/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch_fail.json
[modify] https://crrev.com/6dc08cd4c697ad23c5f3529246e8401a500cc7b2/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch_gen_compile_fail.json
[modify] https://crrev.com/6dc08cd4c697ad23c5f3529246e8401a500cc7b2/scripts/slave/recipes/chromium_codesearch.py

Comment 3 by emso@chromium.org, Dec 17 2016

Status: Verified (was: Assigned)
The build is green again. See crbug/674860 for further improvements in how we connect the configuration to the main waterfall.

Sign in to add a comment