VDA unittest: need a test to call Reset before NotifyFlushDone |
||||||
Issue descriptionWe should have a test case to call Reset before NotifyFlushDone. This is valid and documented in VDA. https://codereview.chromium.org/2556873003. ARC relies on this. This test should catch the bug by the following steps on elm. (1) Revert https://codereview.chromium.org/2506363004 (2) Run debug version of VDA unittest. The test should hit a dcheck in V4L2VideoDecodeAccelerator::StartDevicePoll.
,
Jan 16 2017
Johny. Please take a look.
,
Jan 23 2017
Is going to add a test as follows:
INSTANTIATE_TEST_CASE_P(
ResetBeforeNotifyFlushDone,
VideoDecodeAcceleratorParamTest,
::testing::Values(std::make_tuple(1,
1,
1,
RESET_BEFORE_NOTIFY_FLUSH_DONE,
CS_RESET,
false,
false)));
Which RESET_BEFORE_NOTIFY_FLUSH_DONE(=-5) is the new ResetPoint magic number for VDAClient to send Reset() right after Flush()
,
Jan 24 2017
Sounds good.
,
Feb 15 2017
Ping. Any update?
,
Feb 15 2017
No update here. Will spend some time to finish #3
,
Feb 20 2017
Didn't have time to investigate this yet
,
Mar 14 2017
CL is https://codereview.chromium.org/2713863002/# The original modification will cause win_chromium_rel_ng trybot failure. The root cause is found and we are trying to fix that.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccc25c33b711f0d546fe4edf6b879489ab09cde4 commit ccc25c33b711f0d546fe4edf6b879489ab09cde4 Author: johnylin <johnylin@chromium.org> Date: Wed Mar 15 04:23:20 2017 VDA unittest: test for calling Reset before NotifyFlushDone For VDA it is valid to call Reset() before receiving NotifyResetDone() and VDA should cancel the flush. Add a test to check this scenario. BUG= 674828 TEST= run ResetBeforeNotifyFlushDone test on debug build of Samus: passed. Elm: (1) Test is passed on ToT build. (2) Revert https://codereview.chromium.org/2506363004, test hits dcheck in V4L2VideoDecodeAccelerator::StartDevicePoll() https://cs.chromium.org/chromium/src/media/gpu/v4l2_video_decode_accelerator.cc?dr&l=1840 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2713863002 Cr-Commit-Position: refs/heads/master@{#456990} [modify] https://crrev.com/ccc25c33b711f0d546fe4edf6b879489ab09cde4/media/gpu/video_decode_accelerator_unittest.cc
,
Mar 22 2017
,
May 30 2017
,
Aug 1 2017
,
Nov 6 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vsu...@google.com
, Jan 7 2017