Issue metadata
Sign in to add a comment
|
Regression: Overlapping of text and focus ring is observed in confirmation dialog box for Arabic language.
Reported by
jshan...@etouch.net,
Dec 16 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2926.0 (Official Build)Revision da59d418f54604ba2451cd0ef3a9cd42c05ca530-refs/heads/master@{#433437} (32/64-bit) OS:Windows (7,8,10) Pre-condition: Change browser language to Arabic from chrome://settings/addLanguage What steps will reproduce the problem? (1)Launch chrome and click on avatar icon , sign in with valid credentials. (2)Navigate to chrome://md-settings and click on 'sign out' button. (3)Again sign in with different credentials and press tab key, observe the focus. Actual: Overlapping of text and focus ring is observed after pressing tab key in confirmation dialog box for Arabic language. Expected: No such overlapping should be seen after pressing tab key in confirmation dialog box for Arabic language. This is a regression issue broken in 'M57' and below is bisect info: Using the per-revision bisect providing the bisect results, Good build: 56.0.2924.0 (Revision: 433059). Bad build: 57.0.2926.0 (Revision: 433437). You are probably looking for a change made after 433176 (known good), but no later than 433177 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/09cceadb789bf9836f6f3bb6bd342df94e34b15c..8c24599eb8d95b70cf0a7ed017ca61c843326324 @msarda -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You. Note: Above issue is not seen on Mac and Linux OS
,
Dec 16 2016
,
Dec 16 2016
I suspect there is a bug in the implementation of a paper-radio-button on Windows for RTL languages like Arabic. According to the css file (see https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/signin_shared_css.html?rcl=0&l=41), there should be a spacing of 16px between the button and the label. I'm reassigning this to tjsavage@ (PM for Polymer) for triaging.
,
Dec 21 2016
The Polymer elements, at least for Polymer 1.x, relies on the dir DOM attribute to identify the directionality for a document. When I inspect the signin_email_confirmation dialog i only see: <html i18n-values="dir:textdirection;lang:language"> I would expect to find the dir attribute here, something similar to: <html dir="rtl" lang="ar"> It seems that the i18n-values were not pre-processed.
,
Dec 28 2016
Do you know what I need to do to process this value?
,
Jan 13 2017
Issue is still seen on windows 10 using latest chrome canary M57 #57.0.2979.0 . Could someone provide update on this. Thanks!
,
Jan 13 2017
I came to the same conclusion as comment #4, but I do not know yet why these values are not processed. I'll ask the WebUI owners.
,
Jan 13 2017
I figured it out. I'll put up a CL shortly.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcec08a8f2113594a47067527d4b326aca99ff47 commit dcec08a8f2113594a47067527d4b326aca99ff47 Author: msarda <msarda@chromium.org> Date: Fri Jan 20 11:17:32 2017 Fix html attributes for RTL languages on the signin email confirmation dialog. This CL fixes the direction and the languages attributes for RTL languages on the signin email confirmation dialog. BUG= 674826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2632633005 Cr-Commit-Position: refs/heads/master@{#445038} [modify] https://crrev.com/dcec08a8f2113594a47067527d4b326aca99ff47/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html
,
Jan 20 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jshan...@etouch.net
, Dec 16 2016