Text highlight color does not match Windows 10’s
Reported by
fitosch...@gmail.com,
Dec 16 2016
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.18 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Visit any page not setting its own custom highlight color, e.g., this bug report 2. Highlight some text with the mouse or keyboard. 3. Do the same in a native, non-fancy Windows program such as Notepad What is the expected behavior? Windows 10 Anniversary Update has finally updated the text highligthing color of the default visual style to make it a stronger blue that’s much easier on the eyes than the previous bright shade, introduced since Vista. What went wrong? The highlight color used in Chromium now doesn’t match Windows’, as it can be seen in the attached screenshot. This doesn’t happen in Gecko: Firefox correctly gets the updated strong blue from the Windows visual style. Blink doesn’t seem to get the color from Windows; it looks like it hardcodes the color inside it. Note that this bug only happens in webpages: the browser’s omnibox does pick up the stronger blue when you highlight text in it. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? No Does this work in other browsers? Yes Chrome version: 56.0.2924.18 Channel: dev OS Version: 10.0 Anniversary Update Flash Version: I have observed that the updated strong blue would sometimes revert to the previous Vista one if I suspend my laptop and wake it up. This is of course a bug in Windows 10, but I thought I’d mention it to you to avoid possible confusions.
,
Dec 16 2016
,
Dec 20 2016
Unable to reproduce the issue on win10 chrome dev version 57.0.2950.4 and beta 56.0.2924.28 - highlighting colour seem to be the same on chrome and notepad Please find the screenshot Could you please upgrade to latest dev and see if issue still exists
,
Dec 30 2016
@Again, as I noted in my initial comment: Windows itself does not always use the updated color if you have suspended or hibernated your machine. That is a Windows bug, but Chrome should still be matching Windows’.
,
Jan 4 2017
Tried the same by keeping the machine in sleep mode multiple times but could not see much difference in highlight colour between chrome (57.0.2970.0) and notepad Could you please upgrade to latest dev and see if issue still exists. If yes please try to replicate the same on another system to check if this is system specific
,
Jan 11 2017
Thank you for providing more feedback. Adding requester "tkonchada@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2017
Tested in chrome latest canary # 57.0.2978.0 on win 10.0 and not able to reproduce the issue. @fitoschido: Could you please update on comment #5 and let us know the observation which would help us to triage the issue further. Thanks in Advance.
,
Jan 17 2017
I can still reproduce the issue with Chrome Canary 57.0.2983.0 (64-bit) and Windows 10 version 1607 (build 14393.693). To reproduce the issue, ensure you have not suspended or hibernated your machine and compare the highlight colors of Chrome (with its window focused, as Chrome changes the highlight color to grey when it’s not focused) with the highlight color of Notepad. If you can’t see the difference, use a color picker on the screenshot and compare the hexadecimal values of the colors.
,
Jan 24 2017
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2017
The text color is hard coded in "content/public/common/renderer_preferences.cc"
active_selection_bg_color(SkColorSetRGB(30, 144, 255)),
active_selection_fg_color(SK_ColorWHITE),
inactive_selection_bg_color(SkColorSetRGB(200, 200, 200)),
inactive_selection_fg_color(SkColorSetRGB(50, 50, 50)),
Should we initialized them from ::GetSysColor() Win32 API[2] with
- COLOR_HIGHLIGHT
- COLOR_HIGHLIGHTTEXT
[1] https://cs.chromium.org/chromium/src/content/public/common/renderer_preferences.cc
[2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms724371(v=vs.85).aspx
,
Mar 3 2017
,
Oct 4 2017
,
Oct 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ranjitkan@chromium.org
, Dec 16 2016