New issue
Advanced search Search tips

Issue 674784 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 675811



Sign in to add a comment

memory coordinator doesn't resume suspended renderer

Project Member Reported by bashi@chromium.org, Dec 16 2016

Issue description

On SUSPENDED state change RenderThreadImpl suspends the scheduler but it doesn't resume when the state changes to NORMAL. When the state changes to NORMAL and the scheduler is suspended, we should resume the scheduler.
 

Comment 1 by bashi@chromium.org, Dec 16 2016

Cc: w...@chromium.org
+wez@: FYI

Comment 2 by w...@chromium.org, Dec 16 2016

Should we bump the priority, since MemoryCoordinator doesn't really make sense without this change? :)

Comment 3 by bashi@chromium.org, Dec 16 2016

Labels: -Pri-3 Pri-1
Sure. And I uploaded a fix.
https://codereview.chromium.org/2577313002

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba5d880deafed03fe670da4461db9b7ef6d5645

commit 6ba5d880deafed03fe670da4461db9b7ef6d5645
Author: bashi <bashi@chromium.org>
Date: Mon Dec 19 01:54:37 2016

memory coordinator: Resume suspended renderer on NORMAL state change

Before this CL we don't resume suspended renderer when the suspension was
initiated by memory coordinator (not purge+suspend experiment). We
should resume suspended renderer when the memory state becomes NORMAL.

BUG= 674784 

Review-Url: https://codereview.chromium.org/2577313002
Cr-Commit-Position: refs/heads/master@{#439394}

[modify] https://crrev.com/6ba5d880deafed03fe670da4461db9b7ef6d5645/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/6ba5d880deafed03fe670da4461db9b7ef6d5645/content/renderer/render_thread_impl.h

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a7c6fb8848b1a0100cbafae461a143eb2c83362

commit 0a7c6fb8848b1a0100cbafae461a143eb2c83362
Author: bashi <bashi@chromium.org>
Date: Mon Dec 19 08:51:29 2016

Early return in {Suspend,Resume}Renderer() if not backgrounded

After crrev.com/2564833002, RenderThreadImpl calls SuspendRenderer() and
ResumeRenderer() unconditionally. This could cause assertion failures
when the renderer isn't backgrounded.  Rather than reverting
crrev.com/2564833002, do early return when not backgrounded because
having multiple flags to check whether a renderer is suspended doesn't
sound a good idea.

BUG= 674784 

Review-Url: https://codereview.chromium.org/2583083002
Cr-Commit-Position: refs/heads/master@{#439436}

[modify] https://crrev.com/0a7c6fb8848b1a0100cbafae461a143eb2c83362/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Comment 6 by bashi@chromium.org, Dec 20 2016

Blockedon: 675811
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78811128b957f147a677f72b8df93dd90fc44e1d

commit 78811128b957f147a677f72b8df93dd90fc44e1d
Author: bashi <bashi@chromium.org>
Date: Tue Dec 20 12:23:24 2016

Add tests for calling {Suspend,Resume}Renderer() on foreground renderer

This is a follow-up CL of crrev.com/2583083002. Make sure that calling
these methods doesn't take effect when the renderer is foregrounded.

BUG= 674784 

Review-Url: https://codereview.chromium.org/2583193003
Cr-Commit-Position: refs/heads/master@{#439774}

[modify] https://crrev.com/78811128b957f147a677f72b8df93dd90fc44e1d/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Comment 8 by bashi@chromium.org, Feb 28 2017

Status: WontFix (was: Assigned)
Let me close this as we don't suspend tabs anymore.

Sign in to add a comment