Build error for ARM Linux target in headless/app/headless_shell.cc
Reported by
simon.ho...@arm.com,
Dec 16 2016
|
||||||||
Issue descriptionhttps://codereview.chromium.org/2577483002 introduces a compile error for ARM about comparing an unsigned char with EOF (which is -1). This kills the build. fgetc()'s result should be captured in an int, not a char. I have a patch but I can't get it past presubmit because: ** Presubmit ERRORS ** These files spam the console log with LOG(INFO): headless/app/headless_shell.cc
,
Dec 16 2016
,
Dec 16 2016
,
Dec 16 2016
,
Dec 16 2016
,
Dec 16 2016
You can pass `--bypass-hooks` to `git cl upload` to skip presubmits, and/or add `NOPRESUBMIT=true` to your cl description to make the bots skip it. But that file should probably be added to the spam whitelist in PRESUBMIT.py
,
Dec 16 2016
Aha! It looks like I copy-pasted some kind of unicode hypen from IRC when I got the same advice there. Done. https://codereview.chromium.org/2579773003
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b43d478991126401b0a03ef49438fcdcda961938 commit b43d478991126401b0a03ef49438fcdcda961938 Author: simon.hosie <simon.hosie@arm.com> Date: Mon Dec 19 15:50:24 2016 Use int for fgetc() result in headless_shell Fixes compilation failure introduced by c3ac4fc0. fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and gives the result as an int. If char is unsigned it's impossible for EOF to match, and this results in a compilation error. If char is signed then potentially valid input could match EOF. BUG= 674765 R=altimin@chromium.org, skyostil@chromium.org Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec Review-Url: https://codereview.chromium.org/2579773003 Cr-Commit-Position: refs/heads/master@{#439479} [modify] https://crrev.com/b43d478991126401b0a03ef49438fcdcda961938/headless/app/headless_shell.cc
,
Dec 20 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by cavalcantii@chromium.org
, Dec 16 2016Status: Started (was: Unconfirmed)