New issue
Advanced search Search tips

Issue 674757 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 631270
issue 671363
issue 672913



Sign in to add a comment

Remove windowing related classes from services/ui/public/cpp

Project Member Reported by sky@chromium.org, Dec 15 2016

Issue description

aura-mus is the new windowing client lib, so these classes should be removed.
 

Comment 1 by sky@chromium.org, Dec 15 2016

Blockedon: 631270 671363
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b18f736c212371ac7a8bbe985b44fbf018f1d06

commit 5b18f736c212371ac7a8bbe985b44fbf018f1d06
Author: sky <sky@chromium.org>
Date: Fri Dec 16 05:34:11 2016

Converts services/navigation to use aura-mus

This code won't actually work. There are a couple of things that need
to be fixed for it to work:

. My understanding from looking at the code is that it will create
  multiple WindowTreeClients in the same thread. That can work, but when
  you do that you have to explicitly pass a WindowPortMus to Windows
  when you create them. That's hard in this case because
  DesktopNativeWidgetAura is creating the windows for you. The fix
  isn't hard, probably set the WindowTreeClient in
  DesktopNativeWidgetAura so that it can create WindowPort correctly.

. aura::WindowTreeClientDelegate has a couple of functions that can't
  be implemented in ViewImpl. Specifically getting the capture client
  and a PropertyConverter. The capture client generally comes from
  WMState and the PropertyConverter can be a singleton. It shouldn't
  be that hard to wire these up.

. aura::Env needs to be created with Mode::MUS.

As my understanding is I can't really run this code yet I didn't
pursue the fixes. If there is a way to run this code I can try and
make these fixes, otherwise I would prefer to postpone.

BUG= 674757 
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2585593002
Cr-Commit-Position: refs/heads/master@{#439036}

[modify] https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06/services/navigation/BUILD.gn
[modify] https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06/services/navigation/view_impl.cc
[modify] https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06/services/navigation/view_impl.h

Comment 4 by sky@chromium.org, Jan 3 2017

Blockedon: 672913

Comment 5 by sky@chromium.org, Mar 7 2017

Status: Fixed (was: Untriaged)
This is done. services/ui/public/cpp no longer contains Window or WindowTreeClient.

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment