Remove windowing related classes from services/ui/public/cpp |
||||||
Issue descriptionaura-mus is the new windowing client lib, so these classes should be removed.
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5c029fd74033e88ccca31a0b0dbf5b74d1fc674 commit c5c029fd74033e88ccca31a0b0dbf5b74d1fc674 Author: sky <sky@chromium.org> Date: Fri Dec 16 03:45:31 2016 Removes some dead code and includes No longer needed. BUG= 674757 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2578373002 Cr-Commit-Position: refs/heads/master@{#439009} [modify] https://crrev.com/c5c029fd74033e88ccca31a0b0dbf5b74d1fc674/ash/mus/accelerators/accelerator_controller_registrar.cc [delete] https://crrev.com/4af2926f8b00bd4f18eedab66170dbd021624ce6/ash/mus/bridge/mus_layout_manager_adapter.cc [delete] https://crrev.com/4af2926f8b00bd4f18eedab66170dbd021624ce6/ash/mus/bridge/mus_layout_manager_adapter.h [modify] https://crrev.com/c5c029fd74033e88ccca31a0b0dbf5b74d1fc674/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/c5c029fd74033e88ccca31a0b0dbf5b74d1fc674/ash/mus/test/ash_test_impl_mus.cc [delete] https://crrev.com/4af2926f8b00bd4f18eedab66170dbd021624ce6/mash/example/common/mus_views_init.h
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b18f736c212371ac7a8bbe985b44fbf018f1d06 commit 5b18f736c212371ac7a8bbe985b44fbf018f1d06 Author: sky <sky@chromium.org> Date: Fri Dec 16 05:34:11 2016 Converts services/navigation to use aura-mus This code won't actually work. There are a couple of things that need to be fixed for it to work: . My understanding from looking at the code is that it will create multiple WindowTreeClients in the same thread. That can work, but when you do that you have to explicitly pass a WindowPortMus to Windows when you create them. That's hard in this case because DesktopNativeWidgetAura is creating the windows for you. The fix isn't hard, probably set the WindowTreeClient in DesktopNativeWidgetAura so that it can create WindowPort correctly. . aura::WindowTreeClientDelegate has a couple of functions that can't be implemented in ViewImpl. Specifically getting the capture client and a PropertyConverter. The capture client generally comes from WMState and the PropertyConverter can be a singleton. It shouldn't be that hard to wire these up. . aura::Env needs to be created with Mode::MUS. As my understanding is I can't really run this code yet I didn't pursue the fixes. If there is a way to run this code I can try and make these fixes, otherwise I would prefer to postpone. BUG= 674757 TEST=none R=ben@chromium.org Review-Url: https://codereview.chromium.org/2585593002 Cr-Commit-Position: refs/heads/master@{#439036} [modify] https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06/services/navigation/BUILD.gn [modify] https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06/services/navigation/view_impl.cc [modify] https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06/services/navigation/view_impl.h
,
Jan 3 2017
,
Mar 7 2017
This is done. services/ui/public/cpp no longer contains Window or WindowTreeClient.
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sky@chromium.org
, Dec 15 2016