New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674735 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 644372



Sign in to add a comment

[Findit/Predator] clean up regexes in local_git_parsers.py

Project Member Reported by wrengr@chromium.org, Dec 15 2016

Issue description

In local_git_parsers.py the CHANGED_FILE_PATTERN1 and CHANGED_FILE_PATTERN2 regexes seem too liberal. In particular, why not change the ``(\w)`` to ``([MAD])``, and the ``([A-Z0-9]*)`` to ``([RC][0-9]*)``? The tighter regexes would allow us to fail faster, rather than potentially hiding bugs or failing later when we have less info.
 

Comment 1 by st...@chromium.org, Apr 24 2017

Cc: -kateso...@chromium.org
Components: -Tools>Test>FindIt
Owner: kateso...@chromium.org
Status: Assigned (was: Available)
Status: Archived (was: Assigned)

Sign in to add a comment