New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674731 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 683241



Sign in to add a comment

debugd printer configuration should take ppd files by contents, not file handle

Project Member Reported by justincarlson@chromium.org, Dec 15 2016

Issue description

Right now we jump through a lot of hoops to pass around ppds as file handles.  We should, instead, just pass the ppd contents directly to debugd over dbus -- the size of the largest ppds is comfortably under the limits of dbus, and this eliminates a lot of inter-process coordination about file lifetimes.
 

Comment 1 by skau@chromium.org, Jan 20 2017

Blocking: 683241
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/83f092867190983307074773a93cbcabb88886c3

commit 83f092867190983307074773a93cbcabb88886c3
Author: Justin Carlson <justincarlson@chromium.org>
Date: Thu Jan 05 21:33:08 2017

debugd: Add constants for new debugd dbus hooks.

These are needed to invoke the new dbus api functions being added in
https://chromium-review.googlesource.com/#/c/420974.

BUG= chromium:674731 
TEST=none

Change-Id: I0238e06886b6f5df2b4daeb3bbcafc1d18aa46e1
Reviewed-on: https://chromium-review.googlesource.com/424848
Commit-Ready: Justin Carlson <justincarlson@chromium.org>
Tested-by: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/83f092867190983307074773a93cbcabb88886c3/dbus/debugd/dbus-constants.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af171f93dabf82b5fd0cc566ac3796a7a5ba782

commit 8af171f93dabf82b5fd0cc566ac3796a7a5ba782
Author: justincarlson <justincarlson@chromium.org>
Date: Thu Jan 26 00:58:18 2017

Update chromiumos system_api DEP to pull in recent debugd changes.

BUG= chromium:674731 

Review-Url: https://codereview.chromium.org/2657583006
Cr-Commit-Position: refs/heads/master@{#446182}

[modify] https://crrev.com/8af171f93dabf82b5fd0cc566ac3796a7a5ba782/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017

Comment 5 by adlr@chromium.org, Jan 27 2017

Status: Started (was: Assigned)
Status: Fixed (was: Started)

Sign in to add a comment