New issue
Advanced search Search tips

Issue 674729 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cannot load chrome://md-settings/pointer-overlay directly

Project Member Reported by michae...@chromium.org, Dec 15 2016

Issue description

The pointer overlay has an auto-close function: if all mice & touchpads are removed, it closes itself.

If we try to load the overlay directly, the auto-close triggers, because these devices are detected asynchronously.

For now, let's just disable the auto-close feature, so the page can be loaded (or reloaded) at that URL.
 
Ugh, I'm pretty silly. Don't disable auto-close, there's a much easier fix than I realized.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec33688c7d81592695a5ecc92b198d6883d2a39f

commit ec33688c7d81592695a5ecc92b198d6883d2a39f
Author: michaelpg <michaelpg@chromium.org>
Date: Sat Dec 17 04:29:44 2016

Allow navigation to chrome://md-settings/pointer-overlay

The pointers subpage has some clever logic to close the subpage if all
connected touchpads and mice are detached. But it breaks loading the subpage
directly, because we don't receive the device status synchronously.

Prevent the auto-close logic running too early by not initializing the mouse and
touchpad Polymer properties.

BUG= 674729 
R=dpapad@chromium.org

Review-Url: https://codereview.chromium.org/2585573002
Cr-Commit-Position: refs/heads/master@{#439318}

[modify] https://crrev.com/ec33688c7d81592695a5ecc92b198d6883d2a39f/chrome/browser/resources/settings/device_page/compiled_resources2.gyp
[modify] https://crrev.com/ec33688c7d81592695a5ecc92b198d6883d2a39f/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/ec33688c7d81592695a5ecc92b198d6883d2a39f/chrome/browser/resources/settings/device_page/pointers.js
[modify] https://crrev.com/ec33688c7d81592695a5ecc92b198d6883d2a39f/chrome/test/data/webui/settings/device_page_tests.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS  9107.0.0, 57.0.2957.0

Sign in to add a comment