New issue
Advanced search Search tips

Issue 674719 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove docked-mode notification

Project Member Reported by michae...@chromium.org, Dec 15 2016

Issue description

When the lid of a laptop plugged into an external display is closed, the external display becomes the primary (if it wasn't already) and a notification appears:

[Docked mode]
"You can keep using your Chromebook while it's connected to an external display, even with the lid closed."

I'm tired of seeing this notification every day... is it really necessary?

Why bother to tell me that I can continue using the device.... that I'm using to read this notification telling me that I can continue using the device I'm using?

If we can't remove it, could we at least make it a first-time-only thing, or add the notification directly to the notification list without toasting?
 
Status: Assigned (was: Untriaged)
+afakhry who has recently been improving some of the notifications around multiple monitors & docked mode.

I agree it seems like overkill. I'm not sure why it was initially added, though maybe it was because users were surprised at the external monitor staying on after closing their laptop. Happy to run this past UI Review.
Labels: M-58
Cc: tbuck...@chromium.org
Owner: afakhry@chromium.org
Adding afakhry for real. I'll email UI Review.
We can make it a first-time only notification, if that's desired. Let me know what the UI review will suggest. Thanks.
Cc: derat@chromium.org
UI Review is comfortable with removing this.

+derat, they also asked us to check with you. Any objections?

Comment 7 by derat@chromium.org, Feb 16 2017

I too am annoyed by this when I'm using docked mode repeatedly. Either going first-time-only or dropping it entirely sounds great to me.
UI Review is on board with removing it entirely, so let's make it happen!

@afakhry let me know if you have any questions.
Cc: osh...@chromium.org
SGTM, let's make it happen. +oshima FYI.
sg

Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0829e4642d9eb31f9454be3e6168cffdb4d257

commit da0829e4642d9eb31f9454be3e6168cffdb4d257
Author: afakhry <afakhry@chromium.org>
Date: Thu Feb 23 17:03:24 2017

Remove docked-mode notification

Users found the docked mode events notifications annoying. We decided
to remove them entirely.

BUG= 674719 
TEST=updated tests to reflect new behavior.

Review-Url: https://codereview.chromium.org/2714543003
Cr-Commit-Position: refs/heads/master@{#452521}

[modify] https://crrev.com/da0829e4642d9eb31f9454be3e6168cffdb4d257/ash/ash_chromeos_strings.grdp
[modify] https://crrev.com/da0829e4642d9eb31f9454be3e6168cffdb4d257/ash/system/chromeos/screen_layout_observer.cc
[modify] https://crrev.com/da0829e4642d9eb31f9454be3e6168cffdb4d257/ash/system/chromeos/screen_layout_observer_unittest.cc

Status: Fixed (was: Started)

Comment 14 by son...@google.com, Apr 12 2017

Status: Verified (was: Fixed)
Verified on build 9334.42.0

Sign in to add a comment