New issue
Advanced search Search tips

Issue 674717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Can't save page later after playing the offline dino game

Project Member Reported by dewittj@chromium.org, Dec 15 2016

Issue description

Chrome Version: 57.0.2950.3 dev
Nexus 5x
Android 7.1.1

Steps to repro:
1. Go offline
2. Load a webpage - see offline dino page
3. Tap the dinosaur, play the game
4. Try to tap the download page later button

Expected behavior:
Button works

Actual behavior:
Button causes dinosaur to jump

 
Cc: prashanthpola@chromium.org
Labels: traige-te
Labels: -traige-te triage-te
Cc: -prashanthpola@chromium.org fgor...@chromium.org
Labels: -triage-te M-57
Owner: jianli@chromium.org
Status: Assigned (was: Unconfirmed)
I'm able to reproduce this bug on build 57.0.2950.3 dev/Nexus 5X/7.1.2 

Comment 5 by jianli@chromium.org, Dec 27 2016

Cc: edwardjung@chromium.org
Edward, do you know where to look at this?
Cc: -edwardjung@chromium.org jianli@chromium.org
Owner: edwardjung@chromium.org
Yes, when the game is activated, the whole of the screen acts as a controller for the game. The only current way is reloading the page.

Will need to test having the buttons activated and if it's messes the game. I think this might involve changing the JS as well as the CSS.  


Components: -UI>Browser>Offline UI>Browser>WebUI
Status: Started (was: Assigned)
Okay it's a small change. Putting together a CL now.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ba9599b1b7790fea7aa3d3c2e62860a9345041

commit 73ba9599b1b7790fea7aa3d3c2e62860a9345041
Author: edwardjung <edwardjung@chromium.org>
Date: Tue Jan 10 22:46:13 2017

Allow Download button to be usable when the Dino easter egg is activated
on the offline interstitial

BUG= 674717 

Review-Url: https://codereview.chromium.org/2625553002
Cr-Commit-Position: refs/heads/master@{#442715}

[modify] https://crrev.com/73ba9599b1b7790fea7aa3d3c2e62860a9345041/components/security_interstitials/core/browser/resources/interstitial_v2.css

Status: Fixed (was: Started)

Sign in to add a comment