Remove WebNode/WebElement use in translate_helper.cc |
||||
Issue descriptionCurrently, translate_helper directly crawls the DOM to extract the value of the <html> lang attribute and to check if "notranslate" is set in a <meta> tag. This code should be extracted out to Blink and the uses of WebNode/WebElement should be removed.
,
Dec 15 2016
Why should that be extracted? (I'm not naysaying, but wondering what the rationale is)
,
Dec 15 2016
In general we're working toward removing WebElement/WebNode and friends. They're too low level, slow because they can't use the internal blink types (ex. AtomicString), and lead to often broken code. For example autofill doesn't understand Shadow DOM. See also https://bugs.chromium.org/p/chromium/issues/detail?id=523433
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3 commit 5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3 Author: adithyas <adithyas@chromium.org> Date: Tue Jan 17 21:27:01 2017 Remove use of WebNode/WebElement in translate_helper Moves DOM crawling code to documentLanguage() and hasMetaValues() to WebDocument and Document BUG= 674714 Review-Url: https://codereview.chromium.org/2577203002 Cr-Commit-Position: refs/heads/master@{#444149} [modify] https://crrev.com/5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3/components/translate/content/renderer/translate_helper.cc [modify] https://crrev.com/5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3/third_party/WebKit/Source/web/BUILD.gn [add] https://crrev.com/5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3/third_party/WebKit/Source/web/WebLanguageDetectionDetails.cpp [modify] https://crrev.com/5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3/third_party/WebKit/public/BUILD.gn [add] https://crrev.com/5e61528ed7a6cd174f97e14d4cd29b91f8e8baf3/third_party/WebKit/public/web/WebLanguageDetectionDetails.h
,
Jan 17 2017
,
Apr 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jbroman@chromium.org
, Dec 15 2016