Issue metadata
Sign in to add a comment
|
Notification sound is not played when find result not found in webpage
Reported by
danbo...@gmail.com,
Dec 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 54.0.2840.99 (Official Build) m (64-bit) URLs (if applicable) : N/A Windows Version : Windows 7 Ultimate, Build 7601: Service Pack 1 What steps will reproduce the problem? (1) Head to any Website (2) Press Ctrl+F, and start searching for something like (asdf) What is the expected result? The page should play a "ding" or "beep" sound as soon as I type a character and is unable to find a result on the webpage What happens instead? No "ding" sound is played. Please provide any additional information below. Attach a screenshot if possible. Version 51.0.2704.84 this issue doesn't exist. It appears somewhere around version 53.0.2785.116 the functionality was broken. Also, it appears that it's working as intended, but only if you press the backspace key. (For example: You type asdf1234. If you press backspace after you press the 4, if "asdf123" is not found, it will correctly play the ding sound. This functionality is extremely helpful for users who look at their keyboard when typing. This sound gives feedback that a search result is not found on the page, and the fact that it works when a user presses backspace, hints at the fact that this is most likely a defect.
,
Dec 16 2016
Adding 'Needs-Milestone' label, TE will check the issue and update the bug with comments & tag with respective Mstone
,
Dec 16 2016
Able to reproduce the issue on mac 10.12.2 chrome version 55.0.2883.87 and canary - No "ding" sound This is a regression issue on M54 and below is the info Manual Bisect: Good Build:54.0.2791.0 Bad Build:54.0.2792.0 CL: https://chromium.googlesource.com/chromium/src/+log/54.0.2791.0..54.0.2792.0?pretty=fuller&n=10000 Possible suspect : https://codereview.chromium.org/2093953002 Please reassign if this is not related to your change
,
Dec 16 2016
One more suspect : https://codereview.chromium.org/2127033004 ccing the related dev
,
Dec 16 2016
Both CLs are entirely unrelated. Let's see if the UI>Browser>FindInPage owners can triage accordingly.
,
Dec 19 2016
Bisect Tool Info: You are probably looking for a change made after 404300 (known good), but no later than 404307 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/4c8533dd7c1b9ac29add8014e6ace14a271e6418..53bfbe932191085b Possible suspect : https://codereview.chromium.org/2121513002 Please reassign if this is not related to your change
,
Dec 19 2016
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cce238ff09415dfdb4f6786cfa314a48ae6e8ce commit 6cce238ff09415dfdb4f6786cfa314a48ae6e8ce Author: lazyboy <lazyboy@chromium.org> Date: Tue Dec 20 00:56:33 2016 Fix a find_bar audible alert regression due to r404307. In refactor CL r404307, I mistakenly changed last_search.find(current_search) != 0 to StartsWith(last_search, current_search) instead of !StartsWith(last_search, current_search) This CL fixes the issue. BUG= 674713 Test=Open any webpage, Ctrl+F to start search, start typing some word, audible alert should be heard as soon as the typed characters aren't found on the page. Review-Url: https://codereview.chromium.org/2590673002 Cr-Commit-Position: refs/heads/master@{#439644} [modify] https://crrev.com/6cce238ff09415dfdb4f6786cfa314a48ae6e8ce/chrome/browser/ui/find_bar/find_bar_controller.cc
,
Dec 20 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ligim...@chromium.org
, Dec 16 2016