New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674699 link

Starred by 1 user
Status: Fixed
Owner:
█ justincarlson@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

PPDs from quirks server need to be made safe for JSON string encoding.

Project Member Reported by justincarlson@chromium.org, Dec 15 2016 
Right now we are just shoving raw binary data into an (escaped) JSON string, which is not a valid thing to do.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d98839d33ca4605963e81d8749a00f735c7a4b2

commit 9d98839d33ca4605963e81d8749a00f735c7a4b2
Author: justincarlson <justincarlson@chromium.org>
Date: Fri Dec 16 18:34:36 2016

Base64-decode encoded ppds from the quirksserver, and update tests.

BUG= 674699 

Review-Url: https://codereview.chromium.org/2580973002
Cr-Commit-Position: refs/heads/master@{#439157}

[modify] https://crrev.com/9d98839d33ca4605963e81d8749a00f735c7a4b2/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/9d98839d33ca4605963e81d8749a00f735c7a4b2/chromeos/printing/ppd_provider_unittest.cc

Comment 2 by adlr@chromium.org, Jan 4 2017 

Is this done, or still need to fix the encoding side?

Comment 3 by justincarlson@chromium.org, Jan 4 2017

Status: Fixed (was: Assigned)
This was done.
►

Sign in to add a comment