New issue
Advanced search Search tips

Issue 674693 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Measure WebAudio node constructor usage

Project Member Reported by rtoy@chromium.org, Dec 15 2016

Issue description

It would be good to have metrics on how often the WebAudio node constructors are used (in addition to the existing metrics on the factory methods that we already capture).
 

Comment 1 by rtoy@chromium.org, Dec 19 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a7e96b476a052615c9e7e32ec99d72a8f642d7

commit f9a7e96b476a052615c9e7e32ec99d72a8f642d7
Author: rtoy <rtoy@chromium.org>
Date: Tue Dec 20 23:47:29 2016

Measure WebAudio node constructor usage

Just add "Measure" to every constructible webaudio object so that we
can measure how often the constructors are used.  We already have
metrics for the corresponding factory methods, so this fills the gap
between measuring the past and measuring the future.

No other changes introduced.

BUG= 674693 
TESTS=none

Review-Url: https://codereview.chromium.org/2581813002
Cr-Commit-Position: refs/heads/master@{#439931}

[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/AnalyserNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/AudioBuffer.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/ConvolverNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/DelayNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/GainNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/PannerNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/PeriodicWave.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.idl
[modify] https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7/tools/metrics/histograms/histograms.xml

Comment 3 by rtoy@chromium.org, Dec 22 2016

Status: Fixed (was: Started)

Sign in to add a comment