Issue 674659 link

Starred by 0 users

Issue metadata

Status:	Archived
Owner:	sjg@chromium.org
Closed:	Dec 2016
Cc:	vapier@chromium.org
Components:	OS>Systems
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

chromeos-config: minor touchups

Project Member Reported by vapier@chromium.org, Dec 15 2016

Issue description

some issues with the current code:
- missing a README.md
- -lfdt belongs in 'libraries', not 'ldflags'

Comment 1 by sjg@chromium.org, Dec 16 2016

Status: Assigned (was: Unconfirmed)

Comment 2 by sjg@chromium.org, Dec 16 2016

Status: Started (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/075350702e9806e0363c40429132650ca421e570

commit 075350702e9806e0363c40429132650ca421e570
Author: Simon Glass <sjg@chromium.org>
Date: Fri Dec 16 20:24:36 2016

chromeos-config: Add a README.md

Add a starting point for the README.md. So far this mostly just includes
the binding. Pieces from the design doc will arrive here once things are
implemented.

BUG= chromium:674659 
TEST=Preview the doc in 'retext' and see that it looks reasonable
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: I44586b41241393ef83cb3854805cc718c20261b3
Reviewed-on: https://chromium-review.googlesource.com/421111
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/075350702e9806e0363c40429132650ca421e570/chromeos-config/README.md

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b0766b2865c2ccae2d78221ee024eb4aafaf06d2

commit b0766b2865c2ccae2d78221ee024eb4aafaf06d2
Author: Simon Glass <sjg@chromium.org>
Date: Fri Dec 16 20:25:59 2016

chromeos-config: Use 'link_settings' instead of 'ldflags'

Adjust the .gpy file to use the correct mechanism to specify the dependent
library.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:674659 
TEST=FEATURES=test emerge-reef -q --nodeps chromeos-config-tools
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: Ib93e59ba00a6fecfb6c511daace8e985225932bd
Reviewed-on: https://chromium-review.googlesource.com/421112
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b0766b2865c2ccae2d78221ee024eb4aafaf06d2/chromeos-config/chromeos-config.gyp