[OfflinePages] If user Resume's a webpage download pick that request to run if not currently loading |
|||
Issue descriptionWhen Resuming a WebPage download request (or SavePageRequest), if the Coordinator is not currently processing requests, it will start processing and will choose the request to try without consideration as to the request that the user just resumed so some other pending request may start next. It would be more intuitive to the user that the request selected to Resume should have priority to run next.
,
Feb 25 2017
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b commit 50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b Author: romax <romax@chromium.org> Date: Thu Mar 09 23:31:20 2017 [Offline Pages] Pick correct request when resuming. Fixed the bug where if user resumes a webpage download in notification, the request queue would not honor the priority of the tapped request and pick from all requests using normal logic. BUG= 674653 Review-Url: https://codereview.chromium.org/2729763002 Cr-Commit-Position: refs/heads/master@{#455898} [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/pick_request_task.cc [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/pick_request_task.h [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/pick_request_task_unittest.cc [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/request_coordinator.cc [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/request_coordinator.h [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/request_coordinator_unittest.cc [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/request_queue.cc [modify] https://crrev.com/50952e8e2031ad1f9d59b4f9bcf0682dd08e6f1b/components/offline_pages/core/background/request_queue.h
,
Mar 9 2017
The patch has been landed, however there's still decision to be made: how are we going to prioritize the resumed page downloads?
,
Mar 30 2017
next step tracked in 705106 |
|||
►
Sign in to add a comment |
|||
Comment 1 by chili@chromium.org
, Feb 7 2017