Currently it's possible to have these suggestions: 1- Jon Doe 555-555-5555 2- Jon Doe 3- 555-555-5555 In this case, only the first one should be suggested.
Good catch! :-D
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9 commit 90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9 Author: sebsg <sebsg@chromium.org> Date: Thu Jan 05 21:42:58 2017 [Payments] Dedupe subsets in contact detail suggestions. Previously suggestions that are a subset of another suggestion are not deduped. With this patch, only the most complete version will be suggested to the user. A side-effect of this change is that ContactDetails are now sorted by relevance in regards or the information required from the merchant instead of completeness. For example, considering a profile A with only email and a profile B with email and phone, and a merchant requires email, phone and name. Previously the order between A and B would have been decided by frecency since both were incomplete. With this patch, B would be suggested first since it has more information. BUG= 674647 Review-Url: https://codereview.chromium.org/2583593002 Cr-Commit-Position: refs/heads/master@{#441764} [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/java_sources.gni [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java [add] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java [modify] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [add] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactUnitTest.java [add] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/test/data/android/payments/email_and_phone.js [add] https://crrev.com/90bf8242b2d3f9ffb2bef194f4e065fb81a13ce9/chrome/test/data/android/payments/payment_request_email_and_phone_test.html
Comment 1 by rouslan@chromium.org
, Dec 15 2016