New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674628 link

Starred by 1 user
Status: Fixed
Owner:
chfremer@chromium.org
Closed: Jan 2017
Cc:
█ lunalu@chromium.org
mcasas@chromium.org
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

IsWebcamAvailableOnSystem() in browser_test_utils.h always returns false

Project Member Reported by chfremer@chromium.org, Dec 15 2016 
There is a typo in the JavaScript that checks for the presence of a video input device. The device.kind is checked against 'video-input', but it should be 'videoinput' without the dash.

The check has probably never worked, and this means that all tests that use this check have effectively been disabled on all platforms since it was introduced, see Code Review [1].

The affected tests are:
  chrome/browser/media/webrtc/webrtc_webcam_browsertests.cc [2]
  content/browser/webrtc/webrtc_image_capture_browsertest.cc [3]
  content/browser/webrtc/webrtc_webcam_browsertest.cc [4]

[1] https://codereview.chromium.org/2334223012/
[2] https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc?l=81&cl=GROK
[3] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_image_capture_browsertest.cc?l=100&cl=GROK
[4] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_webcam_browsertest.cc?l=77&cl=GROK
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47

commit b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47
Author: chfremer <chfremer@chromium.org>
Date: Mon Dec 19 21:11:39 2016

Fix typo in JS test code checking for Webcam in browser_test_utils.cc

The typo effectively caused the below tests to not be executed.
After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix.

BUG= 674628 
TEST=
  out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*"
  out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*"
  out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*"

Review-Url: https://codereview.chromium.org/2579183003
Cr-Commit-Position: refs/heads/master@{#439558}

[modify] https://crrev.com/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47/content/public/test/browser_test_utils.cc

Comment 2 by chfremer@chromium.org, Jan 17 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment