Issue metadata
Sign in to add a comment
|
404 errors when trying to snooze items |
||||||||||||||||||||||||
Issue descriptionI'm getting 404 errors when trying to snooze alerts on sheriff-o-matic-staging.appspot.com. Console output attached.
,
Dec 15 2016
I think it's 404-ing because you're trying to snooze something where the key has a '/' in it, which is confusing. Should probably urlencode the key...
,
Dec 15 2016
Possibly related: https://bugs.chromium.org/p/chromium/issues/detail?id=673979
,
Dec 15 2016
My bookmarks have that link; I'll update it to point at the non-staging version. I was trying to snooze an alert for a stable master chromium-fyi bot (which probably shouldn't be on the dashboard at all).
,
Dec 15 2016
Huh, that's strange. The key is currently being run through encodeURIComponent(key) in sendAnnotation. But yeah, it does look like it's not getting encoded here.
,
Dec 15 2016
*stale master chromium-fyi bot
,
Dec 15 2016
https://cs.chromium.org/chromium/build/scripts/slave/gatekeeper_trees.json?q=gatekeeper_trees&sq=package:chromium&l=55 is the line that adds a dependency on chromium.fyi to android. John, we still care about that builder?
,
Dec 15 2016
Yes, as it triggers five of the fyi bots, but I'm not sure about having sheriffs be responsible for anything on fyi.
,
Dec 15 2016
,
Feb 10 2017
Issue 678589 has been merged into this issue.
,
Mar 6 2017
Issue 698758 has been merged into this issue.
,
Mar 6 2017
,
Dec 5 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by martiniss@chromium.org
, Dec 15 2016