New issue
Advanced search Search tips

Issue 674606 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ thinks deleted files are modified

Project Member Reported by csashi@google.com, Dec 15 2016

Issue description

Please explain below why you believe CQ is not working.

This issue was created with help of the "CQ not working?" link on Rietveld.

I uploaded https://codereview.chromium.org/2551683002/#ps20001 where I modified some PNG resources in the first patch set.

In a follow up upload, https://codereview.chromium.org/2551683002/#ps20001, I deleted the PNG resources and replaced them with equivalent vector drawables.

The CL builds fine on my machine and Git shows these files as deleted.
However, https://codereview.chromium.org/2551683002/ continues to show the files as modified and both CQ lint and build fail because it thinks there are two Java resources with same name.

Lint error

chrome/android/java/res/drawable/amex_card.xml The following images appear both as density independent `.xml` files and as bitmap files: chrome/android/java/res/drawable-hdpi/amex_card.png, chrome/android/java/res/drawable/amex_card.xml: IconXmlAndPng [warning]

Build error (https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/199133/steps/compile%20%28with%20patch%29/logs/stdio):

res/drawable/amex_card.xml:0: error: Resource entry amex_card is already defined.
res/drawable/amex_card.png:0: Originally defined here.

I suspect the issue is caused because the first upload modified the file and a subsequent upload deleted it. https://codereview.chromium.org/2551683002/ correctly shows files as deleted for those files that were deleted before prior modification in the CL.

I tried various commands such as git rm -f, rebase, restored the file and then deleted again but that did not help.
 
Components: -Infra>CQ Infra>Codereview>Rietveld
Labels: -Restrict-View-Google
This is actually a Rietveld issue, not CQ.
Also no need for it to be internal.

Please try re-uploading the CL as a workaround:
  git cl issue 0
  git cl upload

I was also not able to reproduce it: https://codereview.chromium.org/2577133002. Most like this will be "fixed" when we'll migrate to Gerrit though.

Comment 2 by csashi@google.com, Dec 15 2016

In your experiment, I believe you added a file  (bugreport-2016-08-05-11-35-48.png) that is not present in the repository that you deleted in a follow up patch set. Can you try
1. modifying a file that is present in the repository (e.g. chrome/android/java/res/drawable-hdpi/amex_card.png),
2. cl upload this change
3. delete the file
4. cl upload this change.
Labels: Pri-2 Type-Bug
Status: Available (was: Untriaged)
Sergiy is correct.

https://polygerrit.appspot.com
Status: WontFix (was: Available)
Closing in bulk due to Rietveld’s deprecation in favor of Gerrit. If you feel this bug should not have been closed, please feel free to re-open.

Sign in to add a comment