browserAction title is set and reset at wrong moments
Reported by
ilyaigpe...@gmail.com,
Dec 15 2016
|
|||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: Bug 1 1. During each `webRequest.onCompleted` of newly opened tab do: 1.1. browserAction.getTitle(cb), inside cb: 1.2. title += '!'; 1.3. browserAction.setTitle 2. According to logs find out, that `cb` receives title not that one set by most recent setTitle, but that one that was during the moment of calling of getTitle. Bug 2 1. Change browserAction title of a tab. 2. Hit F5. 3. getTitle during webRequest.onCompleted of the first request after F5. 4. Notice that you get old title but not freshly new. 5. Also notice that title is reset after first request and subsequent webRequest.onCompleted don't get previously set title but freshly new. What is the expected behavior? Bug 1: cb of getTitle must get title set by most recent setTitle Bug 2 : title is reset before first request, not after it. What went wrong? Bug 1: cb of getTitle receives value of title at the moment of getTitle was called. Bug 2 : title is reset somewhere after first request completed. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 55.0.2883.87 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 24.0 r0 Repository with most recent code for tests: https://github.com/ilyaigpetrov/repository-for-chrome-bugs
,
Dec 16 2016
When unzipped and loaded popup.html observed two buttons Test_one and Test_two. Could not understand further how to proceed, would you mind giving more info to triage further from Test Engg team.
,
Dec 16 2016
+durga.behera, here you are: 1) Load unpacked extension. 2) Open console of background page this way: chrome://extensions, developer mode ON, under "FooBar Extension" click "inspect views: background page". 3) Open popup and click Test_One. 4) Open http://archive.org and look at logs of background page. 5) If you want to repeat test: a) chrome://extensions -> "FooBar Extension" -> reload b) On tab with archive.org press F12 -> Right click on reload button -> clean cache and hard reload. c) See logs of background page. I also left verbose comments inside background.js file -- please, read them too for more clarity. When you are done with the first test, reload extension, open popup and click Test_Two and further steps are the same as for the Test_One.
,
Dec 23 2016
Thank you for providing more feedback. Adding requester "durga.behera@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 28 2016
Tested this issue on windows 10 with chrome version #55.0.2883.87 as steps mentioned in comment #3 Observations 1. On step 3 when i click test_one and test_two, nothing get printed on console 2. When i navigated to archive.org then browsed different pages and their titles getting updated appropriately Attaching screencast for your reference, please look into it and let us know any steps i have missed while reproducing the scenario. Thank You...
,
Jan 2 2017
Hello, +kkaluri. I repost content that was sent you directly via email due to some issues on my side. I recorded screencast for you and also fixed one bug in test two. You may find it in the attachment. +kkaluri, thank you very much for recording the screencast. From your screencast I see that you opened popup.html as you typically open any html file in your filesystem. This won't work because this way popup can't communicate with the installed extension. popup.html must be opened in the context of the extension, not separately from it on filesystem. What you should do is the following: 1. Install unpacked extension from filesystem. 2. Open console of the background page as described in comment #3, step 2. 3. Chrome places icons of installed extensions on the right of the address bar. Find there "FooBar Extension" with letter "F" (it is seen on your screencast) on its icon. Click it. 4. Continue with step 3 of comment #3.
,
Jan 9 2017
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2017
Cleaning up "Needs-Review" label as we are not using this label for triage. Ref bug 684919
,
Mar 13 2017
,
Mar 15 2018
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Dec 16 2016