Issue metadata
Sign in to add a comment
|
DCHECK failed: ValidateImpl(event, &error_msg_). Missing tap ending event before TapDown |
||||||||||||||||||||||
Issue descriptionChrome Version: (57.0.2952.0) OS: Android What steps will reproduce the problem? (1)Do a touch fling and cancel it with tapDown. (2)Hold the tapDown till the longPress timeout expires. (3)Release your finger and do another tapDown. What is the expected result? DCHECK should pass for the second tapDown. What happens instead? It fails because all tap ending events for the previous tapDown are suppressed because of fling cancellation.
,
Dec 15 2016
,
Jan 4 2017
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a0c0947e7f0432e2810c3b008f17a9136c4518f commit 4a0c0947e7f0432e2810c3b008f17a9136c4518f Author: sahel <sahel@chromium.org> Date: Wed Jan 04 16:46:24 2017 Tap suppression controller forwards the next TapCancel when the stashed TapDown is forwarded. When the controller forwards the stashed TapDown event after tapDownTimer expiration, it should forward the next TapCancel event as well to maintain a valid input stream. The rest of the tap ending events should get suppressed till the next TapDown event. BUG= 674602 TEST=TapSuppressionControllerTest.GFCAckBeforeTapSufficientlyLateTapCancel Review-Url: https://codereview.chromium.org/2613533003 Cr-Commit-Position: refs/heads/master@{#441396} [modify] https://crrev.com/4a0c0947e7f0432e2810c3b008f17a9136c4518f/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc [modify] https://crrev.com/4a0c0947e7f0432e2810c3b008f17a9136c4518f/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc [modify] https://crrev.com/4a0c0947e7f0432e2810c3b008f17a9136c4518f/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h
,
Jan 4 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sahel@chromium.org
, Dec 15 2016