New issue
Advanced search Search tips

Issue 674593 link

Starred by 17 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on: View detail
issue 237173
issue 238368
issue 346236
issue 391673
issue 438370
issue 445218
issue 460725
issue 580126
issue 609934
issue 632380
issue 634542
issue 649328
issue 652814
issue 659131
issue 659133
issue 660758
issue 660759
issue 671907
issue 683827
issue 689684
issue 689687
issue 690135
issue 690143
issue 690582
issue 690593
issue 690599
issue 690606
issue 690608
issue 692628
issue 692678
issue 692687
issue 692695
issue 692709
issue 692712
issue 692713
issue 692720
issue 692728
issue 692736
issue 692796
issue 692832
issue 692835
issue 692839
issue 695494
issue 695499
issue 695505
issue 695508
issue 695564
issue 695586
issue 695592
issue 695594
issue 695895
issue 695972
issue 695977
issue 695981
issue 695984
issue 696011
issue 696682
issue 697059
issue 697064
issue 697147
issue 699843
issue 699846
issue 699865
issue 699877
issue 699882
issue 699892
issue 700400
issue 701390
issue 701464
issue 701480
issue 701482
issue 701496
issue 701501
issue 701893
issue 706559
issue 707360
issue 707379
issue 707399
issue 708201
issue 709001
issue 709023
issue 710764
issue 711586
issue 766694
issue 818103
issue 223749
issue 348985
issue 437286
issue 437569
issue 489947
issue 543785
issue 581955
issue 591719
issue 598704
issue 605710
issue 635420
issue 645492
issue 651414
issue 657825
issue 659074
issue 659134
issue 664630
issue 669498
issue 674944
issue 688439
issue 688943
issue 689676
issue 689681
issue 690014
issue 690600
issue 690601
issue 690609
issue 692631
issue 692639
issue 692652
issue 692665
issue 692698
issue 692700
issue 692703
issue 692717
issue 692718
issue 693513
issue 695504
issue 695506
issue 695572
issue 695597
issue 695891
issue 695902
issue 695996
issue 696005
issue 696010
issue 696013
issue 696669
issue 696681
issue 697068
issue 697110
issue 697121
issue 697123
issue 697137
issue 697163
issue 697167
issue 697170
issue 697378
issue 697598
issue 698163
issue 698853
issue 699873
issue 699902
issue 700267
issue 701229
issue 701391
issue 701392
issue 701397
issue 701422
issue 701431
issue 701457
issue 701472
issue 701475
issue 701476
issue 701477
issue 701493
issue 701498
issue 701499
issue 705685
issue 706561
issue 707338
issue 707341
issue 707347
issue 707351
issue 707365
issue 707371
issue 707382
issue 707386
issue 707392
issue 707898
issue 708189
issue 708195
issue 708206
issue 709008
issue 709013
issue 709019
issue 711577
issue 726510
issue 769221
issue 816352
issue 898991

Blocking:
issue 673852



Sign in to add a comment

Standardize or remove non-standard parts of Blink's IDL

Project Member Reported by foolip@chromium.org, Dec 15 2016

Issue description

Blink's IDL files have many interfaces, attributes, methods, etc. that are not in any spec. Many have never been considered for standardization, while other were once in a spec but were then removed.

For each of these APIs, we should aim to either standardize it and see it implemented in all engines, or removed from Blink and any other engine that implement it.

Advise on how to tackle these issues is in this "Finding a path to interop" document:
https://docs.google.com/document/d/1LSuLWJDP02rlC9bOlidL6DzBV5kSkV5bW5Pled8HGC8/edit?usp=sharing
 
Showing comments 146 - 245 of 245 Older
Blockedon: -695582
Blockedon: 700267
Blockedon: 693513
Blockedon: 700400
Blockedon: 701229
Blockedon: -695906
Blockedon: 391673
Blockedon: 701390
Blockedon: 701391
Blockedon: 701392
Blockedon: 701397
Blockedon: 701422
Blockedon: 634542
Blockedon: 701431
Blockedon: 701441
Blockedon: 701443
Blockedon: 701456
Blockedon: 701457
Blockedon: 701459
Blockedon: 701464
Blockedon: 701472
Blockedon: 701474
Blockedon: 701475
Blockedon: 701476
Blockedon: 701477
Blockedon: 701479
Blockedon: 701480
Blockedon: 701482
Blockedon: 701493
Blockedon: 701496
Blockedon: 701498
Blockedon: 701499
Blockedon: 701501
Blockedon: -701479
Blockedon: 701893
Blockedon: -701474
Blockedon: -701456
Blockedon: -701443
Blockedon: -701441
Blockedon: -701459
Description: Show this description
Blockedon: 705685
Blockedon: 706559
Blockedon: 707338
Blockedon: 707341
Blockedon: 545318
Blockedon: 707347
Blockedon: 460725
Blockedon: 707351
Blockedon: 609934
Blockedon: 665919
Blockedon: 706561
Blockedon: 707360
Blockedon: 707365
Blockedon: 688439
Blockedon: 657825
Blockedon: 664630
Blockedon: 707371
Blockedon: 659074
Blockedon: 707379
Blockedon: 707382
Blockedon: 707386
Blockedon: 707392
Blockedon: 707399
Blockedon: 707898
Blockedon: -665919
Blockedon: -545318
Blockedon: 708189
Blockedon: 708195
Blockedon: 652814
Blockedon: 708201
Blockedon: 708206
Blockedon: 709001
Blockedon: 709008
Blockedon: 238368
Blockedon: 709013
Blockedon: 709019
Blockedon: 709023
I am attaching a CSV files of (open) the blocking bugs as of now. This is in order to later be able to tell how many have been resolved in Q2, or later.
blocking-674593-20170406.csv
31.2 KB View Download
Blockedon: 710764
Blockedon: 711577
Blockedon: 711586
Project Member

Comment 229 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba3e08e72dbeacfc92d01648ac93a72a26257d36

commit ba3e08e72dbeacfc92d01648ac93a72a26257d36
Author: jsbell <jsbell@chromium.org>
Date: Tue Apr 25 21:00:51 2017

IndexedDB: Add [SameObject] / [NewObject] annotations per spec

A recent spec change [1] to IndexedDB [2] adds the [SameObject] [3] and
[NewObject] [4] IDL extended attributes to properties and methods as
appropiate. These don't change the behavior (which was described by
algorithmic prose) but allow implementations/tests to make additional
assertions about the behavior of the interfaces.

[1] https://github.com/w3c/IndexedDB/commit/05b2a7c5d65a497c49c8636021fc1cc791fdc9c9
[2] https://w3c.github.io/IndexedDB/
[3] https://heycam.github.io/webidl/#SameObject
[4] https://heycam.github.io/webidl/#NewObject

BUG=674593
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2837613003
Cr-Commit-Position: refs/heads/master@{#467108}

[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBCursor.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBFactory.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBKeyRange.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBRequest.idl
[modify] https://crrev.com/ba3e08e72dbeacfc92d01648ac93a72a26257d36/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.idl

Project Member

Comment 230 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0626510c113d95afa8aa15666a81bb25fc7fbda3

commit 0626510c113d95afa8aa15666a81bb25fc7fbda3
Author: jsbell <jsbell@chromium.org>
Date: Wed Apr 26 00:57:51 2017

IndexedDB: Remove DOMStringList special case for transaction()

Now that sequence conversion handles iterables, we no longer need
a special case for IDBDatabase's transaction() method which takes
a union of (DOMString or sequence<DOMString>) to accept DOMStringList.
The method signature now matches the spec.

BUG=674593
TEST=storage/indexeddb/transaction-basics.html

Review-Url: https://codereview.chromium.org/2840893002
Cr-Commit-Position: refs/heads/master@{#467188}

[modify] https://crrev.com/0626510c113d95afa8aa15666a81bb25fc7fbda3/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/0626510c113d95afa8aa15666a81bb25fc7fbda3/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/0626510c113d95afa8aa15666a81bb25fc7fbda3/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
[modify] https://crrev.com/0626510c113d95afa8aa15666a81bb25fc7fbda3/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.idl
[modify] https://crrev.com/0626510c113d95afa8aa15666a81bb25fc7fbda3/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Blockedon: 543785
Blockedon: 726510
Blockedon: 697378
Attaching a new CSV files of the issues that are blocking today, for Q3 OKR scoring.
blocking-674593-20170704.csv
26.4 KB View Download
Blockedon: 769221
Blockedon: 660758
Blockedon: 223749
Blockedon: 816352
Blockedon: 818103
Labels: Hotlist-Interop
Blockedon: 766694
Project Member

Comment 242 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e13925e9de78a42421c5a4e8c884ef9dea97849

commit 5e13925e9de78a42421c5a4e8c884ef9dea97849
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Aug 30 04:30:26 2018

IDL: Move [Unforgeable] on Location interface to its members

An IDL extended attribute `[Unforgeable]` is not applicable
on interfaces, but we have it on Location interface.
This CL removes it from interface definition and applies
it on its members (operations and attributes) to follow
Web IDL spec and HTML spec.


Bug: 674593
Change-Id: I295d7c80a39304d7ec497c0492ca6061c153036a
Reviewed-on: https://chromium-review.googlesource.com/1194528
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587442}
[modify] https://crrev.com/5e13925e9de78a42421c5a4e8c884ef9dea97849/third_party/blink/renderer/core/frame/location.idl

Project Member

Comment 243 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0ee3d48025f31776bc33cd38b36df0504a02f3

commit ee0ee3d48025f31776bc33cd38b36df0504a02f3
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Fri Aug 31 09:13:29 2018

IDL compiler: Disable to put [Unforgeable] on interfaces or static members

In WebIDL spec, [Unforgeable] can appear on interface attributes
and interface non-static operations.
https://heycam.github.io/webidl/#Unforgeable

Now our IDL compiler does not check its use cases.
This CL makes IDL compiler to check if [Unforgeable] appears on
interfaces or static members, and stops with a warning message
if it does.


Bug: 674593
Change-Id: I6f17834eae71b3c7aa44556c3442f679091efd59
Reviewed-on: https://chromium-review.googlesource.com/1198711
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587973}
[modify] https://crrev.com/ee0ee3d48025f31776bc33cd38b36df0504a02f3/third_party/blink/renderer/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/ee0ee3d48025f31776bc33cd38b36df0504a02f3/third_party/blink/renderer/bindings/scripts/compute_interfaces_info_individual.py
[modify] https://crrev.com/ee0ee3d48025f31776bc33cd38b36df0504a02f3/third_party/blink/renderer/bindings/scripts/idl_definitions.py
[modify] https://crrev.com/ee0ee3d48025f31776bc33cd38b36df0504a02f3/third_party/blink/renderer/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/ee0ee3d48025f31776bc33cd38b36df0504a02f3/third_party/blink/renderer/bindings/scripts/v8_methods.py
[modify] https://crrev.com/ee0ee3d48025f31776bc33cd38b36df0504a02f3/third_party/blink/renderer/bindings/scripts/v8_utilities.py

Labels: -Hotlist-Interop
Blockedon: 898991
Showing comments 146 - 245 of 245 Older

Sign in to add a comment