New issue
Advanced search Search tips

Issue 674575 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 671363



Sign in to add a comment

Replace WebContentsViewMus and related classes with aura-mus

Project Member Reported by sky@chromium.org, Dec 15 2016

Issue description

The old client lib is going away.
 

Comment 1 by sky@chromium.org, Dec 15 2016

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f58580288ec06e8196db11ee9280b5eabac1b5ad

commit f58580288ec06e8196db11ee9280b5eabac1b5ad
Author: sky <sky@chromium.org>
Date: Fri Dec 16 17:22:11 2016

Fixes bug in ServerWindowCompositorFrameSinkManager

It was assuming there is always a root window, which isn't the
case. GetRootWindow() only returns non-null when attached to a
display, so if a window has a parent but isn't yet attached to a
display then GetRoot returns null.

BUG= 674575 
TEST=none
R=fsamuel@chromium.org

Review-Url: https://codereview.chromium.org/2580703005
Cr-Commit-Position: refs/heads/master@{#439132}

[modify] https://crrev.com/f58580288ec06e8196db11ee9280b5eabac1b5ad/services/ui/ws/server_window.cc
[modify] https://crrev.com/f58580288ec06e8196db11ee9280b5eabac1b5ad/services/ui/ws/server_window.h
[modify] https://crrev.com/f58580288ec06e8196db11ee9280b5eabac1b5ad/services/ui/ws/server_window_compositor_frame_sink_manager.cc
[modify] https://crrev.com/f58580288ec06e8196db11ee9280b5eabac1b5ad/services/ui/ws/server_window_compositor_frame_sink_manager.h

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52a39e34c68e7e37138c666eccdd836a1162415a

commit 52a39e34c68e7e37138c666eccdd836a1162415a
Author: sky <sky@chromium.org>
Date: Sat Dec 17 17:23:22 2016

Removes WebContentsViewMus/RenderWidgetHostViewMus

I updated the aura-mus classes to support mus.

BUG= 674575 
TEST=none
R=ben@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2577023003
Cr-Commit-Position: refs/heads/master@{#439344}

[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/BUILD.gn
[add] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/renderer_host/delegated_frame_host_client_aura.cc
[add] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/renderer_host/delegated_frame_host_client_aura.h
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[delete] https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31/content/browser/renderer_host/render_widget_host_view_mus.cc
[delete] https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/content/browser/web_contents/web_contents_view_aura.cc
[delete] https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31/content/browser/web_contents/web_contents_view_mus.cc
[delete] https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31/content/browser/web_contents/web_contents_view_mus.h
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/mash/package/mash_packaged_service.cc
[modify] https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a/ui/aura/mus/window_tree_client.cc

Comment 4 by sky@chromium.org, Jan 3 2017

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment