New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674572 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

WebGL test 'misc/large-loop-compile' flaky on Windows D3D9

Project Member Reported by sugoi@chromium.org, Dec 15 2016

Issue description

D3D9 uses an older shader compiler that doesn't deal as well with complicated shaders.

Example failing build:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/8417

======================================================================
FAIL: WebglConformance_conformance_glsl_misc_large_loop_compile (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\b\s\w\irauysdc\third_party\catapult\telemetry\telemetry\testing\serially_executed_browser_test_case.py", line 155, in <lambda>
    return lambda self: based_method(self, *args)
  File "c:\b\s\w\irauysdc\content\test\gpu\gpu_tests\gpu_integration_test.py", line 78, in _RunGpuTest
    self.RunActualGpuTest(url, *args)
  File "c:\b\s\w\irauysdc\content\test\gpu\gpu_tests\webgl_conformance_integration_test.py", line 196, in RunActualGpuTest
    getattr(self, test_name)(test_path, *args[1:])
  File "c:\b\s\w\irauysdc\content\test\gpu\gpu_tests\webgl_conformance_integration_test.py", line 210, in _RunConformanceTest
    self._CheckTestCompletion()
  File "c:\b\s\w\irauysdc\content\test\gpu\gpu_tests\webgl_conformance_integration_test.py", line 206, in _CheckTestCompletion
    self.fail(self._WebGLTestMessages(self.tab))
AssertionError: Shader compilation took an unreasonably long time
FAIL Shader compilation took an unreasonably long time

 
Components: Blink>WebGL
Owner: sugoi@chromium.org
Status: Assigned (was: Untriaged)
We should just skip this test on D3D9.. one of the original reasons to switch to D3D11 was to solve the problem of compiling shaders like the one in this test. Alexis Feel free to close this out once you land the skip.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c63801f23cfe47242a116a140423237ffdd95edd

commit c63801f23cfe47242a116a140423237ffdd95edd
Author: sugoi <sugoi@chromium.org>
Date: Thu Dec 15 16:09:37 2016

Skipped a flaky D3D9 test

The 'large-loop-compile.html' test fails regularly on D3D9 due to D3D9
using an older shader compiler which doesn't deal well with complicated
shaders. Skipping the test on D3D9 to avoid future failures.

TBR=zmo@chromium.org,kbr@chromium.org
NOTRY=true
BUG= 674572 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2578163002
Cr-Commit-Position: refs/heads/master@{#438838}

[modify] https://crrev.com/c63801f23cfe47242a116a140423237ffdd95edd/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 3 by kbr@chromium.org, Dec 20 2016

Thanks. Suppressing this sounds fine. Feel free to close as WontFix.

Status: WontFix (was: Assigned)

Sign in to add a comment