Performance dashboard identified a 0.4% regression in sizes/libcronet.so on android_cronet_arm64_builder_dbg at revision range 438471:438471. Graph: https://chromeperf.appspot.com/report?masters=ChromiumAndroid&bots=android_cronet_arm64_builder_dbg&tests=sizes%2Flibcronet.so&checked=libcronet.so%2Clibcronet.so_ref%2Cref&rev=438471 x84: https://chromeperf.appspot.com/report?sid=4698b023c03e2203dde8108f68a6e288223bab4a6920ec538f10e377353553fb&rev=438471 PartitionAlloc is moved from blink to base/ (https://chromium.googlesource.com/chromium/src/+/a988c5022f9bc4fb75ac0b86dda8005ee57ff357). This caused a 0.4% increase (~32Kb) in Cronet binaries on arm64 and x84. Since PartitionAlloc is being developed for more parts of chromium and it is not yet used, Cronet can exclude the sources.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7519f1f1bff997fade77a4dec1f4bcbe2bc858aa commit 7519f1f1bff997fade77a4dec1f4bcbe2bc858aa Author: xunjieli <xunjieli@chromium.org> Date: Thu Dec 15 16:14:26 2016 Add a GN arg to include PartitionAlloc sources This CL adds a GN arg so that the PartitionAlloc sources can be included or excluded. Since PartitionAlloc is still under development and not used by all components that depend on base/, this will give an option to binary size sensitive projects(e.g. Cronet) to not bear the size increase in the meanwhile. BUG= 674570 Review-Url: https://codereview.chromium.org/2575973002 Cr-Commit-Position: refs/heads/master@{#438842} [modify] https://crrev.com/7519f1f1bff997fade77a4dec1f4bcbe2bc858aa/base/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f405a0b4e2d49c05f2d6d9b05aa620a72647c917 commit f405a0b4e2d49c05f2d6d9b05aa620a72647c917 Author: xunjieli <xunjieli@chromium.org> Date: Mon Dec 19 15:17:17 2016 [Cronet] Use use_partition_alloc GN arg in Cronet Use use_partition_alloc=false GN arg in Cronet BUG= 674570 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2577173002 Cr-Commit-Position: refs/heads/master@{#439477} [modify] https://crrev.com/f405a0b4e2d49c05f2d6d9b05aa620a72647c917/components/cronet/tools/cr_cronet.py [modify] https://crrev.com/f405a0b4e2d49c05f2d6d9b05aa620a72647c917/tools/mb/mb_config.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/33c5e23d1949c433885abd3884719d67988c1f98 commit 33c5e23d1949c433885abd3884719d67988c1f98 Author: xunjieli <xunjieli@chromium.org> Date: Tue Dec 20 17:44:53 2016 [Cronet] set use_partition_alloc to false in Cronet recipes BUG= 674570 Review-Url: https://codereview.chromium.org/2593683002 [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipe_modules/chromium_android/chromium_config.py [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipe_modules/cronet/example.expected/gn_test.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipe_modules/cronet/example.expected/local_test.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_tester.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/cronet_try.json [modify] https://crrev.com/33c5e23d1949c433885abd3884719d67988c1f98/scripts/slave/recipes/cronet.expected/local_test.json
Comment 1 by bugdroid1@chromium.org
, Dec 15 2016