New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674568 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 666647



Sign in to add a comment

Do not show time for Physical Web suggestions.

Project Member Reported by vitaliii@chromium.org, Dec 15 2016

Issue description

We decided not to show time for Physical Web suggestions.
 
Confirmed with Patrick, we do not show time.
Labels: zine-16-12-19
Status: Started (was: Assigned)
Screenshots to patch 3 from the CL.
English + Hebrew publisher.png
365 KB View Download
Hebrew + English publisher.png
353 KB View Download
English in RTL.png
221 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac0bb8bf760c4a783fdbe2f176711585b1a070e

commit 3ac0bb8bf760c4a783fdbe2f176711585b1a070e
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Dec 22 14:06:47 2016

[NTP::PhysicalWeb] Do not show published time.

In this CL:
1) published time for Physical Web suggestions is not provided anymore;
2) UI is changed not to show published time at all if it is equal to
   NULL time.

BUG= 674568 

Review-Url: https://codereview.chromium.org/2591673002
Cr-Commit-Position: refs/heads/master@{#440407}

[modify] https://crrev.com/3ac0bb8bf760c4a783fdbe2f176711585b1a070e/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/3ac0bb8bf760c4a783fdbe2f176711585b1a070e/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified in M57-57.0.2790.0 build
physicalweb.png
348 KB View Download

Sign in to add a comment