Sharing icons should be stripped out of distilled vision |
||||||||
Issue descriptionChrome Version: M57.0.2952.0 OS: iOS 10. What steps will reproduce the problem? (1) Go to http://www.shorouknews.com/columns/view.aspx?cdate=25112016&id=552d06bc-53af-4298-b6a2-60acf23f6ce6 (2) Add to reading list (tap overflow menu, then share icon) (3) Go to airplane mode (4) Open article from Reading List (4) View distilled (i.e. offline) version What is the expected result? Article should not have the Facebook, WhatsApp, Twitter icon right under the header What happens instead? Formatting is kind of broken. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Dec 22 2016
,
Jan 17 2017
,
Feb 23 2017
This is similar to issue 692553. The element we want to block is: <div class="socialArea">
,
Feb 27 2017
,
Feb 27 2017
,
Feb 28 2017
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c28f91b4b5d5b035973fdec95350503e17453dd6 commit c28f91b4b5d5b035973fdec95350503e17453dd6 Author: wychen <wychen@chromium.org> Date: Wed Mar 01 02:48:34 2017 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/5da487862e...489c6609cb Picked up changes: 489c660 Skip some social sharing elements BUG= 674557 ,692553,696556 Review-Url: https://codereview.chromium.org/2728483002 Cr-Commit-Position: refs/heads/master@{#453797} [modify] https://crrev.com/c28f91b4b5d5b035973fdec95350503e17453dd6/DEPS [modify] https://crrev.com/c28f91b4b5d5b035973fdec95350503e17453dd6/third_party/dom_distiller_js/README.chromium
,
Apr 14 2017
Should this be marked as fixed now? I tested this on Bling Dev M59 and the distillation looks right to me. Thank you !
,
Apr 14 2017
You're welcome. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by olivierrobin@chromium.org
, Dec 15 2016Status: Assigned (was: Untriaged)