New issue
Advanced search Search tips

Issue 674542 link

Starred by 2 users
Status: Fixed
Owner:
jsb...@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674507
issue 332325



Sign in to add a comment

StorageInfo should be a dictionary, not an interface

Project Member Reported by foolip@chromium.org, Dec 15 2016 
https://w3c.github.io/quota-api/#storageinfo-dictionary

In Blink's StorageInfo.idl, it's a dictionary:

[
    NoInterfaceObject,
    RuntimeEnabled=QuotaPromise
] interface StorageInfo {
    readonly attribute unsigned long long usage;
    readonly attribute unsigned long long quota;
};

Noticed because it also has NoInterfaceObject.

Comment 1 by jsb...@chromium.org, Dec 15 2016 

Dead end API but easy fix....

Comment 2 by foolip@chromium.org, Dec 15 2016 

Is it on a path to removal from the web platform? If so keeping as interface will retain the option to add use counters for usage and quota, which isn't possible with a dictionary.

Comment 3 by jsb...@chromium.org, Dec 15 2016

Owner: jsb...@chromium.org
Status: Started (was: Untriaged)
The entry point is measurable.

Comment 4 by foolip@chromium.org, Dec 15 2016 

Ah, great!

Comment 5 by jsb...@chromium.org, Dec 15 2016 

And actually we never shipped this one. :P

CL to remove the whole thing:

https://codereview.chromium.org/2410403002/

I've just been waiting on shipping navigator.storage.estimate() before proposing removing this. And shipping estimate() is gated on HEIST mitigation work.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57115fe5f118545fac3d9c6e463e8f801335c782

commit 57115fe5f118545fac3d9c6e463e8f801335c782
Author: jsbell <jsbell@chromium.org>
Date: Fri Dec 16 04:13:12 2016

Quota: StorageInfo should be a dictionary

BUG= 674542 
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2585563002
Cr-Commit-Position: refs/heads/master@{#439018}

[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/LayoutTests/storage/quota/storagequota-query-info-expected.txt
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/LayoutTests/storage/quota/storagequota-query-info.html
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/LayoutTests/storage/quota/storagequota-request-persistent-quota-expected.txt
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/LayoutTests/storage/quota/storagequota-request-persistent-quota.html
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/Source/modules/quota/BUILD.gn
[delete] https://crrev.com/3cbfdb12dd2c2cdba58608c4f8318a6f7eaf15b8/third_party/WebKit/Source/modules/quota/StorageInfo.cpp
[delete] https://crrev.com/3cbfdb12dd2c2cdba58608c4f8318a6f7eaf15b8/third_party/WebKit/Source/modules/quota/StorageInfo.h
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/Source/modules/quota/StorageInfo.idl
[modify] https://crrev.com/57115fe5f118545fac3d9c6e463e8f801335c782/third_party/WebKit/Source/modules/quota/StorageQuotaCallbacksImpl.cpp

Comment 7 by jsb...@chromium.org, Dec 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment