Add behind-the-flag import/export buttons in MD passwords settings |
|||||||
Issue descriptionThe import/export feature of password manager is behind chrome://flags/#password-import-export and currently in development (umbrella bug 341477). For easy partial testing and development, the feature has a minimal UI (two buttons: export and import) in the (old) settings page chrome://settings/passwords. This is hidden behind the flag as well, not meant to be the final design, but to provide access to the feature for developers and testers. These buttons are missing in the MD settings page. As the MD settings page is being rolled out, this presents an issue of import/export being inaccessible even with the flag on. This bug tracks adding the same two provisional buttons to the MD settings page (currently chrome://md-settings/passwords).
,
Dec 15 2016
Just a note to myself about how to do this: * Add a <paper-button> in chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html; see chrome/browser/resources/settings/reset_page/reset_profile_dialog.html for an example * Add a click handler for it, sending a simple message, in chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js * Add a PasswordManagerImpl method in chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js handling that message; update the |listeners| dictionary; the method should use the passwordsPrivate extensions API * Extend PasswordsPrivateEventRouter (chrome/browser/extensions/api/passwords_private/passwords_private_event_router.*) to handle the new API; figure out how that propagates to chrome/browser/extensions/api/passwords_private/passwords_private_delegate*, the implementation of which can talk to PasswordManagerPresenter * The current import/export handling is done in PasswordManagerHandler (added in https://codereview.chromium.org/1193143003); the handler can use the presenter, but not vice versa, so the handling should probably be moved up to the presenter * As for tests: - chrome/test/data/webui/settings/passwords_and_forms_browsertest.js should check the part until the message is received - chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc with a test delegate can test that the event routing works OK - chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc can test the delegate itself, if we perhaps separate the PasswordManagerPresenter into a mockable API and implementation - (the above will also come handy for adding tests for the handler) - the tests from chrome/browser/ui/webui/options/password_manager_handler_unittest.cc will need to be transformed to presenter tests as well
,
Apr 27 2017
,
Apr 27 2017
(If anybody wants this, just let me know, happy to pass this on you. I have it assigned to keep it in my TODO queue, but am unlikely to get to this soon.)
,
Apr 28 2017
,
May 2 2017
,
Jun 7 2017
Issue 730112 has been merged into this issue.
,
Sep 13 2017
I've started work on this bug here: https://chromium-review.googlesource.com/c/chromium/src/+/663380 Screenshot of the current design attached.
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc0d25e5617550213aa178703d2d620ded1d59e9 commit bc0d25e5617550213aa178703d2d620ded1d59e9 Author: Nathanael Alcock <varkor@google.com> Date: Tue Sep 26 15:11:47 2017 Add password import/export buttons in MD Password Manager settings This change reimplements the import/export functionality to the PM settings as it existed in the previous version, before the Material redesign. Bug: 674536 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I686dc1152e95bc74ad21c3137b5aebf226801aed Reviewed-on: https://chromium-review.googlesource.com/663380 Commit-Queue: Nathanael Alcock <varkor@google.com> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504372} [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/extensions/api/passwords_private/passwords_private_api.h [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/ui/passwords/password_manager_porter.cc [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/common/extensions/api/passwords_private.idl [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/chrome/test/data/extensions/api_test/passwords_private/test.js [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/extensions/browser/extension_event_histogram_value.h [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/bc0d25e5617550213aa178703d2d620ded1d59e9/third_party/closure_compiler/externs/passwords_private.js
,
Sep 26 2017
,
Sep 29 2017
Issue 732446 has been merged into this issue.
,
Oct 1 2017
I really miss this feature. I have multiple desktops and laptops, some not connected to the internet all the time. I use these for software testing and the only time they are hooked to the internet is to download items. On these machines I manually add the passwords and bookmarks via a usb flash drive with the info on it. Without this function I can no longer do this.
,
Oct 2 2017
dwarfstar1959@: The feature got re-introduced with the commit listed in Comment 10. Right now it is available in Chrome Canary, and will be available in the other Chrome versions in the near future.
,
Oct 14 2017
I miss this feature!!! Hope your next release has it again!
,
Oct 29 2017
Just a heads-up: The button will appear in Chrome 63, but due to maintenance, it won't export any passwords until version 64.
,
Nov 20 2017
,
Dec 23 2017
@ vabr@chromium.org, to clarify do we have support for import & export in version 64? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vabr@chromium.org
, Dec 15 201642.8 KB
42.8 KB View Download