New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674535 link

Starred by 1 user
Status: Assigned
Owner:
u...@chromium.org
Cc:
ahaas@chromium.org
mstarzinger@chromium.org
clemensh@chromium.org
█ hpayer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow pointers to new space objects in code object header.

Project Member Reported by u...@chromium.org, Dec 15 2016 
Currently we allow code -> new space references in code body.

But code header cannot point to new space because we are missing write barriers in CopyCode (and maybe other places).

We should add the missing write barriers and allow code header to reference the new space objects.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/02ae44b77d37b1c2828cd1ab2ee7644b6d047338

commit 02ae44b77d37b1c2828cd1ab2ee7644b6d047338
Author: clemensh <clemensh@chromium.org>
Date: Mon Jan 09 13:58:40 2017

Forbid storing objects in new space in Code header

If you try to store an object in new space to the Code header, it will
be added to the store buffer, and a DCHECK will fail later, since Code
objects should never occur in the store buffer.

This CL adds DCHECKs to catch such assignments early. Once we handle
this case better, they can be removed again.

R=mstarzinger@chromium.org, ulan@chromium.org
BUG=chromium:674535

Review-Url: https://codereview.chromium.org/2587073002
Cr-Commit-Position: refs/heads/master@{#42142}

[modify] https://crrev.com/02ae44b77d37b1c2828cd1ab2ee7644b6d047338/src/objects-inl.h
►

Sign in to add a comment