Implement a cookies and site data counter |
||
Issue descriptionIn the Clear Browsing Data dialog, the "Cookies and cache" option currently doesn't have a proper data volume counter; only a generic sentence explaining that this will sign the user out of most websites. As the "Cookies and cache" option would become more prominent with planned UI changes, it should have its own counter. As discussed with maxwalker@, we will count the number of sites that have cookies or site data stored.
,
Dec 19 2016
I implemented counting for cookies, local- and session-storage and everything handled by quota-manager (filesystem, websql, appcache, indexeddb, cachestorage). Still missing are: durable permissions, site usage data, channel ids and plugin data. I guess these should be handled too because they are also deleted with site data? What should the UI say? I'm currently counting the unique number of origins that have some kind of cookie or site_data which is affected. Should it be "Cookies and other site data - 42 sites"?
,
Dec 21 2016
I implemented counting for the remaining data types now. There seems to be a problem that a few entries remain for some time after deletion or are immediately recreated. Especially in session/localstorage.
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04af4448e4833d6d1e9e06059ab9947a4d936111 commit 04af4448e4833d6d1e9e06059ab9947a4d936111 Author: dullweber <dullweber@chromium.org> Date: Mon Mar 06 11:39:03 2017 Count number of origins with data affected by clearing "cookies and site data". BUG= 674526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2594723002 Cr-Commit-Position: refs/heads/master@{#454851} [modify] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/BUILD.gn [modify] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/browsing_data_counter_factory.cc [modify] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/browsing_data_counter_utils.h [add] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/site_data_counter.cc [add] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/site_data_counter.h [add] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/site_data_counting_helper.cc [add] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/site_data_counting_helper.h [add] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/browser/browsing_data/site_data_counting_helper_unittest.cc [modify] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/chrome/test/BUILD.gn [modify] https://crrev.com/04af4448e4833d6d1e9e06059ab9947a4d936111/components/browsing_data_strings.grdp
,
Mar 14 2017
The cookie counter is implemented and will be used in the new CBD UI on Android. |
||
►
Sign in to add a comment |
||
Comment 1 by msramek@chromium.org
, Dec 15 2016