New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674522 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.3%-18.5% regression in blink_perf.dom at 437836:437867

Project Member Reported by pmeenan@chromium.org, Dec 15 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 15 2016

Mergedinto: 673754
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : SELECT element: Fix a bug that intrinsic width is too narrow in less-than-100% zoom level.
Author  : tkent
Commit description:
  
This is a regression by  crbug.com/432795 .  Scrollbar thickness is fixed regardless
of zoom level.  So popup width was too narrow in less-than-100% zoom level.

With this CL, popupInternalPaddingEnd() returns zoomed value as ever if zoom level
is 100%+, and returns a value based on actual scrollbar thickness otherwise.

Also, popupIntenalPaddingEnd() respects to the actual scrollbar thickness instead
of returning fixed '18' pixel.  The default scrollbar thickness on Windows is 17.
popupInternalPaddingEnd() returns 1 + <scrollbar thickness>.

We need to update ThemePainterDefault::setupMenuListArrow() so that it can support
variable width of scrollbars.

Summary of behavior changes:

All platforms except Mac:
  menulist box is wider in less-than-100% zoom level.

Windows Aura theme:
  menulist box is not changed in 100%+ zoom level.

Non-Windows Aura theme and Mock theme:
  menulist box  is narrower by 2px because scrollbar thickness is 15px.

BUG= 667236 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2560733002
Cr-Commit-Position: refs/heads/master@{#437864}
Commit  : 0151427d8ecd6ff854cffb3b741673ab043f7bd0
Date    : Mon Dec 12 14:10:20 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@437841  325.247  20.7018  30  good
chromium@437853  322.425  10.1833  30  good
chromium@437859  325.173  12.1244  30  good
chromium@437862  325.441  27.1167  30  good
chromium@437863  327.796  25.3974  30  good
chromium@437864  290.691  10.6327  30  bad    <--
chromium@437865  297.455  16.2277  30  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 674522

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom
Test Metric: select-single-remove/select-single-remove
Relative Change: 8.54%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1978
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8993203368077494464


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5795414287056896

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment