New issue
Advanced search Search tips

Issue 674509 link

Starred by 1 user
Status: Fixed
Owner:
robertphillips@chromium.org
Closed: Jun 2017
Cc:
fmalita@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Suppress layout tests for upcoming Skia DEPS roll

Project Member Reported by robertphillips@chromium.org, Dec 15 2016 
The Skia CL https://skia-review.googlesource.com/c/5939/ (Add a deferred copy surface (take 2)) altered/will alter the following layout tests:

  compositing/overlap-blending/reflection-opacity-huge.html [ Failure ]
  compositing/reflections/animation-inside-reflection.html [ Failure ]
  compositing/reflections/deeply-nested-reflections.html [ Failure ]
  compositing/reflections/load-video-in-reflection.html [ Failure ]
  compositing/reflections/nested-reflection-anchor-point.html [ Failure ]
  compositing/reflections/nested-reflection-animated.html [ Failure ]
  compositing/reflections/nested-reflection-mask-change.html [ Failure ]
  compositing/reflections/nested-reflection-opacity.html [ Failure ]
  media/video-layer-crash.html [ Failure ]

If anything the new images look better, particularly the following tests:
   compositing/reflections/nested-reflection-anchor-point.html
   compositing/reflections/nested-reflection-animated.html

In the rest of the tests the differences are imperceptible.

See https://codereview.chromium.org/2567403003/ (Roll src/third_party/skia/ 24f19780d..2e018f548)
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ae116ed44a614985286907883c73d2ad948494

commit a2ae116ed44a614985286907883c73d2ad948494
Author: robertphillips <robertphillips@google.com>
Date: Thu Dec 15 14:23:56 2016

Add layout test suppressions for upcoming Skia DEPS roll

The forthcoming Skia CL https://skia-review.googlesource.com/c/5939/ (Add a deferred copy surface) will change these layout tests for the better.

BUG= 674509 

Review-Url: https://codereview.chromium.org/2575403004
Cr-Commit-Position: refs/heads/master@{#438826}

[modify] https://crrev.com/a2ae116ed44a614985286907883c73d2ad948494/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27600d56f1efa8bb7fc789c1d7f9a2b30b40fdd

commit c27600d56f1efa8bb7fc789c1d7f9a2b30b40fdd
Author: robertphillips <robertphillips@google.com>
Date: Thu Dec 15 22:04:18 2016

Rebaseline layout tests after Skia DEPS roll

https://skia-review.googlesource.com/c/6109/ (Add a deferred copy surface) rolled into Chrome at r438850 in https://codereview.chromium.org/2583513002 (Roll src/third_party/skia/ ebccb8268..625cd9e0c) so these layout tests can be rebaselined

BUG= 674509 

Review-Url: https://codereview.chromium.org/2585523002
Cr-Commit-Position: refs/heads/master@{#438933}

[modify] https://crrev.com/c27600d56f1efa8bb7fc789c1d7f9a2b30b40fdd/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bca52942ca29189fca88b1ee30b0746299620b7

commit 4bca52942ca29189fca88b1ee30b0746299620b7
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Dec 21 06:22:03 2016

Auto-rebaseline for r438933

https://chromium.googlesource.com/chromium/src/+/c27600d56f

BUG= 674509 
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2591183002 .
Cr-Commit-Position: refs/heads/master@{#440045}

[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/overlap-blending/reflection-opacity-huge-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/deeply-nested-reflections-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/load-video-in-reflection-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-mask-change-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-opacity-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/deeply-nested-reflections-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-mask-change-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/deeply-nested-reflections-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-mask-change-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.png
[modify] https://crrev.com/4bca52942ca29189fca88b1ee30b0746299620b7/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.txt
[delete] https://crrev.com/b0bd9f154090bdd80e0cceee518d86bac3b52062/third_party/WebKit/LayoutTests/platform/win7/media/video-layer-crash-expected.png
[delete] https://crrev.com/b0bd9f154090bdd80e0cceee518d86bac3b52062/third_party/WebKit/LayoutTests/platform/win7/media/video-layer-crash-expected.txt
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b6b77e8bc9184368758ca9a4dc777f27724eca2

commit 8b6b77e8bc9184368758ca9a4dc777f27724eca2
Author: robertphillips <robertphillips@google.com>
Date: Fri Jan 06 15:25:08 2017

Re-enabled pre-existing suppression after auto-rebaseline

BUG= 674509 

Review-Url: https://codereview.chromium.org/2610323003
Cr-Commit-Position: refs/heads/master@{#441942}

[modify] https://crrev.com/8b6b77e8bc9184368758ca9a4dc777f27724eca2/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by robertphillips@chromium.org, Jun 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment