New issue
Advanced search Search tips

Issue 674478 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 845530



Sign in to add a comment

Add Polymer custom elements + lint/test process to Tricium frontend

Project Member Reported by emso@chromium.org, Dec 15 2016

Issue description

Comment 1 by emso@chromium.org, Dec 15 2016

Status: Available (was: Untriaged)

Comment 2 by emso@chromium.org, Dec 20 2016

Labels: -Pri-2 Pri-3

Comment 3 by emso@chromium.org, Jan 11 2017

Labels: Tricium
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug Type-Feature
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
I was looking into the way that SOM is set up earlier this week; I think that this will be a good thing to do to set up for any future web UI of Tricium (even though web UI for Tricium will be quite simple and isn't very critical right now).
Status: Started (was: Assigned)
Status: Assigned (was: Started)
I'll keep this open until:

 - there is at least 1 custom element in the web UI
 - there is a lint/test process for any custom elements
Labels: -Hotlist-Recharge-Cold
Owner: ----
Status: Available (was: Assigned)
Summary: Add Polymer to Tricium frontend (custom elements + lint/test process) (was: Add polymer to Tricium)
Summary: Add Polymer custom elements + lint/test process to Tricium frontend (was: Add Polymer to Tricium frontend (custom elements + lint/test process))
Blocking: 845530
Labels: -Pri-3 Pri-1
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
Changing priority since I'd like to do this before adding a feedback stats page (bug 845530). There are several other web apps to look at in infra when deciding how to do this; I think for now I may want to use SOM as a model of roughly how to do this, although of course the Tricium frontend should be much simpler than SOM.
Project Member

Comment 13 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/48aa04fb07e0892db724b077aa0e98cef2f696d0

commit 48aa04fb07e0892db724b077aa0e98cef2f696d0
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri May 25 17:55:24 2018

[tricium] Change the run page to fetch Progress JSON

This changes removes run.go and changes the run page
just fetch data from the Progress RPC endpoint.

The run page was made partly for debugging and partly
to provide a link that comments can link to for more
details about a Tricium run.

I think that the data from the Progress RPC response
should probably be sufficient.

Next changes to do after this include:
 - Set up a polymer elements directory with tests
 - Add an element for showing run progress
 - Add a main app entry point element which routes
   based on path
 - Add an element for showing tables or charts of
   "not useful" over time

Bug:  674478 
Change-Id: Iab369f79b6588a8ad1e94dbd8c30cd32a3c521d6
Reviewed-on: https://chromium-review.googlesource.com/1070998
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[delete] https://crrev.com/3f5294472241ef835c3bd9b627c41d892ee21649/go/src/infra/tricium/appengine/templates/pages/run.html
[modify] https://crrev.com/48aa04fb07e0892db724b077aa0e98cef2f696d0/go/src/infra/tricium/appengine/common/common.go
[delete] https://crrev.com/3f5294472241ef835c3bd9b627c41d892ee21649/go/src/infra/tricium/appengine/frontend/run_test.go
[delete] https://crrev.com/3f5294472241ef835c3bd9b627c41d892ee21649/go/src/infra/tricium/appengine/templates/includes/base.html
[delete] https://crrev.com/3f5294472241ef835c3bd9b627c41d892ee21649/go/src/infra/tricium/appengine/frontend/run.go
[modify] https://crrev.com/48aa04fb07e0892db724b077aa0e98cef2f696d0/go/src/infra/tricium/appengine/templates/pages/index.html
[modify] https://crrev.com/48aa04fb07e0892db724b077aa0e98cef2f696d0/go/src/infra/tricium/appengine/frontend/init.go
[modify] https://crrev.com/48aa04fb07e0892db724b077aa0e98cef2f696d0/go/src/infra/tricium/appengine/static/static/style.css

Project Member

Comment 14 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/341d9b3a6ef95acd73449d37e713c926a3a68a27

commit 341d9b3a6ef95acd73449d37e713c926a3a68a27
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue May 29 20:16:37 2018

[tricium] Simplify template usage

The previous templating logic was good for a website with multiple template
pages, but the plan for the tricium front-end is to use a single main page
with different views depending on path, with routing done on the front-end.

With this in mind, template usage can be simplified, and the templates
directory can be replaced with a single index.html.

This is based on the model of some other apps in the infra repository
such as sheriff-o-matic and tree-status.

Bug:  674478 
Change-Id: I582ed1dea702778606bef3f40444feb20d0dca15
Reviewed-on: https://chromium-review.googlesource.com/1074220
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/341d9b3a6ef95acd73449d37e713c926a3a68a27/go/src/infra/tricium/appengine/frontend/handlers_test.go
[modify] https://crrev.com/341d9b3a6ef95acd73449d37e713c926a3a68a27/go/src/infra/tricium/appengine/common/common.go
[modify] https://crrev.com/341d9b3a6ef95acd73449d37e713c926a3a68a27/go/src/infra/tricium/appengine/frontend/handlers.go
[rename] https://crrev.com/341d9b3a6ef95acd73449d37e713c926a3a68a27/go/src/infra/tricium/appengine/frontend/index.html
[delete] https://crrev.com/f0e89bb55b2eb7bb199797132e9795a056686d9c/go/src/infra/tricium/appengine/frontend/templates
[modify] https://crrev.com/341d9b3a6ef95acd73449d37e713c926a3a68a27/go/src/infra/tricium/appengine/frontend/init.go
[delete] https://crrev.com/f0e89bb55b2eb7bb199797132e9795a056686d9c/go/src/infra/tricium/appengine/static/static/style.css

Components: Infra>Platform>Tricium
Components: -Infra>CodeAnalysis
Labels: -Tricium
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f7f1775b20e1498b952cb12a83c2e9e2e458d57a

commit f7f1775b20e1498b952cb12a83c2e9e2e458d57a
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jun 29 23:26:11 2018

[tricium] Add an initial UI set-up using lit-element

Differences of the lit-element version from the Polymer 3 version:

Data binding features of lit-element are less than for Polymer,
so some Polymer elements are less useful, e.g. app-route and iron-ajax.
These can be replaced and done in other ways, e.g. the pwa-helpers
package has a simpler router.

Demos:
 - Main page: https://16127-565f231-tainted-qyearsley-dot-tricium-dev.appspot.com/
 - Feedback page: https://16127-565f231-tainted-qyearsley-dot-tricium-dev.appspot.com/feedback/Hello
 - Run page: https://16127-565f231-tainted-qyearsley-dot-tricium-dev.appspot.com/run/5731880649359360

Bug:  674478 
Change-Id: Ibad3031deef406f73b7ad9d4e2d9e75c3204b055
Reviewed-on: https://chromium-review.googlesource.com/1109216
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/README.md
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/wct.conf.json
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/.eslintrc.json
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/test/index.html
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/test/tricium-feedback-test.html
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/test/tricium-run-test.html
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/.gitignore
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/src/prpc.js
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/index.html
[delete] https://crrev.com/dc3924673ea02213c58bbaa2ff381a483ce66572/go/src/infra/tricium/appengine/frontend/.gitignore
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/package.json
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/src/tricium-feedback.js
[modify] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/app.yaml
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/src/tricium-app.js
[modify] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/init.go
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/src/tricium-run.js
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/package-lock.json
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/polymer.json
[delete] https://crrev.com/dc3924673ea02213c58bbaa2ff381a483ce66572/go/src/infra/tricium/appengine/frontend/Makefile
[delete] https://crrev.com/dc3924673ea02213c58bbaa2ff381a483ce66572/go/src/infra/tricium/appengine/frontend/bower.json
[modify] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/handlers.go
[delete] https://crrev.com/dc3924673ea02213c58bbaa2ff381a483ce66572/go/src/infra/tricium/appengine/frontend/index.html
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/Makefile
[add] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/frontend/ui/test/tricium-app-test.html
[modify] https://crrev.com/f7f1775b20e1498b952cb12a83c2e9e2e458d57a/go/src/infra/tricium/appengine/Makefile

Status: Fixed (was: Assigned)

Sign in to add a comment