New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674462 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Tool tip for Long profile Name is seen missing

Project Member Reported by mmanchala@chromium.org, Dec 15 2016

Issue description

Chrome Version: 57.0.2952.0
OS: Ubuntu 14.04,Windows,Mac

What steps will reproduce the problem?
(1)Launch chrome ->click on avatar icon -> Now click on profile Name.
(2)Type long name to profile -> Now hover mouse on profile name and observe for Tool tip (Please refer Video)

Expected: Tool tip should be seen for long profile name.
Actual: Instead No Tool tip is seen.

This is Regression Issue broken in M-54

Manual good and Bad Builds:
Good Build: 54.0.2789.0
Bad Build:  54.0.2790.0

CHANGELOG URL::
https://chromium.googlesource.com/chromium/src/+log/9d8cb06549e0a67c82d3519954ef9bb01911c8df..478d83e5b642df214eea6a01d8a3a46b6b44cf1c

Suspecting https://codereview.chromium.org/2052473003 from Changelog

@Rogerta :  Please feel free to re-assign if its not related to your change

Note: Unable to assign Issue to the respective owner(Janeliulwq) hence assigning it to Reviewer(Rogerta).

 
Actual_Tooltip.ogv
1.4 MB View Download
Expected_Tooltip.ogv
1.2 MB View Download
Expected_Tooltip.jpg
130 KB View Download
@rogerta -- Gentle remainder. Could you please look into the issue and provide us any update.
Thank You.
Owner: msarda@chromium.org
Assigning to Mihai as the new chrome identity lead.

Comment 3 by msarda@chromium.org, Jan 13 2017

Cc: ew...@chromium.org
Owner: jlebel@chromium.org
Re-assiging to Jerome (new owner for UI>Browser>Profiles).

Comment 4 by ew...@chromium.org, Jan 17 2017

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Removing RBS and downgrading priority.

Comment 5 by jlebel@chromium.org, Jan 20 2017

I notice there is no tooltip in the other profiles in the menu (the ones that are not active). I've looked in the macOS code, there is an explicit test to not put tool tips if MaterialDesignUserMenu is true.

https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm?q=profile_chooser_controller.mm&sq=package:chromium&dr&l=2380

I didn't look at the code on linux, but the toolt tips are no displayed on other profiles also.

Do we want to put tool tips for all profiles in this menu? Or do we want to put tool tips only for the current profile?
I would definitely prefer to have tool tips for all profiles (of course, only the name are too long).

Comment 6 by ew...@chromium.org, Jan 20 2017

Seems reasonable to put in tooltips for all profile names that are cut off because they're too long. Why would we explicitly suppress the tool tip? Seems like an a11y issue.

Comment 7 by jlebel@chromium.org, Jan 20 2017

I'm not sure to understand the point, but this is the reason:
https://codereview.chromium.org/2239443003

Comment 8 by ew...@chromium.org, Jan 20 2017

Cc: hwi@chromium.org
Hmmmm, the fact that Jane explicitly made a CL for this makes me think she talked to someone who works on MD UI in Chrome and that there was some decision about not showing tooltips.

I don't really know why that would be the case though. Unfortunately Jane was an intern so we can't ask her now. +Hwi, is there any reason we wouldn't want to add tooltips for long profile names to the MD user menu?
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce01de43097d69f127f2637d9c3398ff780462a

commit bce01de43097d69f127f2637d9c3398ff780462a
Author: jlebel <jlebel@chromium.org>
Date: Mon Feb 06 11:33:18 2017

Linux/Windows: Remove NonInteractiveContainer from the profile chooser.

This CL replaces the NonInteractiveContainer class by a View class. The only
goal from NonInteractiveContainer was to return false from
CanProcessEventsWithinSubtree().

This view only contains a Label which has no interaction with the mouse. The
only difference is enabling tool tips.

BUG= 674462 

Review-Url: https://codereview.chromium.org/2633183002
Cr-Commit-Position: refs/heads/master@{#448228}

[modify] https://crrev.com/bce01de43097d69f127f2637d9c3398ff780462a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c50e876921535e569078385a0d022cdd8b15a8e7

commit c50e876921535e569078385a0d022cdd8b15a8e7
Author: jlebel <jlebel@chromium.org>
Date: Tue Feb 07 10:01:36 2017

macOS: Adding tooltip in the profile chooser

This CL adds a tooltip for the profile name and the email address
in the profile chooser on macOS.

BUG= 674462 

Review-Url: https://codereview.chromium.org/2632293002
Cr-Commit-Position: refs/heads/master@{#448579}

[modify] https://crrev.com/c50e876921535e569078385a0d022cdd8b15a8e7/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Status: Fixed (was: Assigned)
Labels: Hotlist-Polish
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9823bcf8d6c7063484cdc8c7b1948a9735ace7a

commit f9823bcf8d6c7063484cdc8c7b1948a9735ace7a
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri Feb 17 05:05:52 2017

Revert of Linux/Windows: Remove NonInteractiveContainer from the profile chooser. (patchset #1 id:1 of https://codereview.chromium.org/2633183002/ )

Reason for revert:
Broke button highlight when hovering over name or email labels.  See  crbug.com/693222 

Original issue's description:
> Linux/Windows: Remove NonInteractiveContainer from the profile chooser.
>
> This CL replaces the NonInteractiveContainer class by a View class. The only
> goal from NonInteractiveContainer was to return false from
> CanProcessEventsWithinSubtree().
>
> This view only contains a Label which has no interaction with the mouse. The
> only difference is enabling tool tips.
>
> BUG= 674462 
>
> Review-Url: https://codereview.chromium.org/2633183002
> Cr-Commit-Position: refs/heads/master@{#448228}
> Committed: https://chromium.googlesource.com/chromium/src/+/bce01de43097d69f127f2637d9c3398ff780462a

TBR=msarda@chromium.org,rogerta@chromium.org,pkasting@chromium.org,jlebel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 674462 , 693222 

Review-Url: https://codereview.chromium.org/2701693003
Cr-Commit-Position: refs/heads/master@{#451222}

[modify] https://crrev.com/f9823bcf8d6c7063484cdc8c7b1948a9735ace7a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Status: Assigned (was: Fixed)
Reopening because of the revert in #13
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eded7142ea9f7ff109e9b3a5606cac4161aafbdb

commit eded7142ea9f7ff109e9b3a5606cac4161aafbdb
Author: jlebel <jlebel@chromium.org>
Date: Wed Mar 01 11:24:45 2017

Linux/Windows: Adding tooltip in profile switcher menu.

The current profile item menu displays the photo, the profile name and
the email (only if the user is signed in). To display the profile name
and the email one top of the other, the class NonInteractiveContainer is
used. This view blocks the tooltips (see
View::CanProcessEventsWithinSubtree()).

To solve this problem, this NonInteractiveContainer view is removed and
replaced by a GridLayout to be able to show the profile icon on the left,
and the profile name and the email on the right.

Impact for the current profile in the following cases:
  - Guest profile
  - Supervised profile
  - Not logged in
  - Logged in
  - Not logged in with account consistency flag
  - Logged in with account consistency flag

Screenshot on Linux: https://drive.google.com/drive/folders/0ByXziH_JVCGJbExCUkJSeWdmbVk?usp=sharing
Tested on windows by msarda

BUG= 674462 

Review-Url: https://codereview.chromium.org/2710543002
Cr-Commit-Position: refs/heads/master@{#453904}

[modify] https://crrev.com/eded7142ea9f7ff109e9b3a5606cac4161aafbdb/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment